fix: emit warn when using some sync apis in async callback (#555)

* fix: emit warn when using some sync apis in async callback

* stamp: word

* stamp: oops

Author: nyannyacha

ext/runtime/js/bootstrap.js

@@ -408,7 +408,9 @@ const MAKE_HARD_ERR_FN = (msg) => {
 const DENIED_DENO_FS_API_LIST = ObjectKeys(fsVars)
   .reduce(
     (acc, it) => {
-      acc[it] = MAKE_HARD_ERR_FN(`Deno.${it} is blocklisted`);
+      if (fsVars[it] !== void 0) {
+        acc[it] = MAKE_HARD_ERR_FN(`Deno.${it} is blocklisted`);
+      }
       return acc;
     },
     {},
@@ -685,9 +687,8 @@ globalThis.bootstrapSBEdge = (opts, ctx) => {
     };
 
     if (ctx?.useReadSyncFileAPI) {
-      apisToBeOverridden["readFileSync"] = true;
-      apisToBeOverridden["readTextFileSync"] = true;
-      apisToBeOverridden["openSync"] = true;
+      apisToBeOverridden["readFileSync"] = "warnIfRuntimeIsAlreadyInit";
+      apisToBeOverridden["readTextFileSync"] = "warnIfRuntimeIsAlreadyInit";
     }
 
     const apiNames = ObjectKeys(apisToBeOverridden);
@@ -723,6 +724,20 @@ globalThis.bootstrapSBEdge = (opts, ctx) => {
             };
             break;
           }
+          case "warnIfRuntimeIsAlreadyInit": {
+            const originalFn = Deno[name];
+            Deno[name] = (...args) => {
+              if (ops.op_is_runtime_init()) {
+                return originalFn(...args);
+              } else {
+                globalThis.console.error(
+                  `WARNING: Do not use Deno.${name} inside the async callback. This has performance impacts and will be disallowed in the future.\nUse the async version instead.`,
+                );
+                return originalFn(...args);
+              }
+            };
+            break;
+          }
         }
       }
     }