fix: some methods in node:crypto cause panic (#567)

Author: nyannyacha

Cargo.lock

@@ -57,7 +57,7 @@ tokio.workspace = true
 url.workspace = true
 winapi.workspace = true
 
-aead-gcm-stream = "0.3"
+aead-gcm-stream = "0.4"
 blake2 = "0.10.6"
 const-oid = "0.9.5"
 digest = { version = "0.10.5", features = ["core-api", "std"] }

ext/node/Cargo.toml

@@ -4,6 +4,7 @@ use aes::cipher::block_padding::Pkcs7;
 use aes::cipher::BlockDecryptMut;
 use aes::cipher::BlockEncryptMut;
 use aes::cipher::KeyIvInit;
+use aes::cipher::KeySizeUser;
 use deno_core::error::type_error;
 use deno_core::error::AnyError;
 use deno_core::Resource;
@@ -126,7 +127,7 @@ impl Cipher {
             "aes-192-ecb" => Aes192Ecb(Box::new(ecb::Encryptor::new(key.into()))),
             "aes-256-ecb" => Aes256Ecb(Box::new(ecb::Encryptor::new(key.into()))),
             "aes-128-gcm" => {
-                if iv.len() != 12 {
+                if key.len() != aes::Aes128::key_size() {
                     return Err(type_error("IV length must be 12 bytes"));
                 }
 
@@ -135,7 +136,7 @@ impl Cipher {
                 Aes128Gcm(Box::new(cipher))
             }
             "aes-256-gcm" => {
-                if iv.len() != 12 {
+                if key.len() != aes::Aes256::key_size() {
                     return Err(type_error("IV length must be 12 bytes"));
                 }
 
@@ -302,7 +303,7 @@ impl Decipher {
             "aes-192-ecb" => Aes192Ecb(Box::new(ecb::Decryptor::new(key.into()))),
             "aes-256-ecb" => Aes256Ecb(Box::new(ecb::Decryptor::new(key.into()))),
             "aes-128-gcm" => {
-                if iv.len() != 12 {
+                if key.len() != aes::Aes128::key_size() {
                     return Err(type_error("IV length must be 12 bytes"));
                 }
 
@@ -311,7 +312,7 @@ impl Decipher {
                 Aes128Gcm(Box::new(decipher))
             }
             "aes-256-gcm" => {
-                if iv.len() != 12 {
+                if key.len() != aes::Aes256::key_size() {
                     return Err(type_error("IV length must be 12 bytes"));
                 }
 

ext/node/ops/crypto/cipher.rs

@@ -433,7 +433,7 @@ export function privateEncrypt(
   const padding = privateKey.padding || 1;
 
   buffer = getArrayBufferOrView(buffer, "buffer");
-  return op_node_private_encrypt(data, buffer, padding);
+  return Buffer.from(op_node_private_encrypt(data, buffer, padding));
 }
 
 export function privateDecrypt(
@@ -444,7 +444,7 @@ export function privateDecrypt(
   const padding = privateKey.padding || 1;
 
   buffer = getArrayBufferOrView(buffer, "buffer");
-  return op_node_private_decrypt(data, buffer, padding);
+  return Buffer.from(op_node_private_decrypt(data, buffer, padding));
 }
 
 export function publicEncrypt(
@@ -455,7 +455,7 @@ export function publicEncrypt(
   const padding = publicKey.padding || 1;
 
   buffer = getArrayBufferOrView(buffer, "buffer");
-  return op_node_public_encrypt(data, buffer, padding);
+  return Buffer.from(op_node_public_encrypt(data, buffer, padding));
 }
 
 export function prepareKey(key) {