Skip to content

Commit de41c79

Browse files
committed
[img-proxy]: configure max thumbnail width and height
1 parent 7b486dc commit de41c79

File tree

6 files changed

+17
-3
lines changed

6 files changed

+17
-3
lines changed

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,12 @@ imgProxy:
3939
enabled: true
4040
url: "http://localhost:8081"
4141
localFilePath: "/tmp/group-challenge-cache"
42-
thumbnailQuality: 75
42+
thumbnailQuality: 90
43+
maxThumbnailWidth: 420
44+
maxThumbnailHeight: 420
4345
fullSizeQuality: 75
46+
maxFullWidth: 1280
47+
maxFullHeight: 1280
4448
```
4549
4650
## Local development

api/config.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ imgProxy:
1616
url: "http://localhost:8081"
1717
sharedLocalCacheDir: "/tmp/group-challenge-cache"
1818
thumbnailQuality: 90
19+
maxThumbnailWidth: 420
20+
maxThumbnailHeight: 420
1921
fullSizeQuality: 75
2022
maxFullWidth: 1280
2123
maxFullHeight: 1280

api/main.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,9 @@ func init() {
3737
viper.SetDefault("imgProxy.enabled", false)
3838
viper.SetDefault("imgProxy.url", "http://localhost:8081")
3939
viper.SetDefault("imgProxy.sharedLocalCacheDir", "/tmp/group-challenge-cache")
40-
viper.SetDefault("imgProxy.thumbnailQuality", 75)
40+
viper.SetDefault("imgProxy.thumbnailQuality", 90)
41+
viper.SetDefault("imgProxy.maxThumbnailWidth", 420)
42+
viper.SetDefault("imgProxy.maxThumbnailHeight", 420)
4143
viper.SetDefault("imgProxy.fullSizeQuality", 75)
4244
viper.SetDefault("imgProxy.maxFullWidth", 1280)
4345
viper.SetDefault("imgProxy.maxFullHeight", 1280)

api/pkg/group-challenge/api/image-api.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
// see: https://docs.imgproxy.net/generating_the_url
2323
func serveThumbnailImageHandler(c *gin.Context) {
2424
if imgProxyConfig.Enabled {
25-
imgProxy(c, fmt.Sprintf("width:%d/height:%d/quality:%d", 150, 150, imgProxyConfig.ThumbnailQuality))
25+
imgProxy(c, fmt.Sprintf("width:%d/height:%d/quality:%d", imgProxyConfig.MaxThumbnailWidth, imgProxyConfig.MaxThumbnailHeight, imgProxyConfig.ThumbnailQuality))
2626
} else {
2727
serveFallbackImageHandler(c)
2828
}

api/pkg/group-challenge/config/config.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ type ImgProxyConfig struct {
3838
URL string
3939
SharedLocalCacheDir string
4040
ThumbnailQuality int
41+
MaxThumbnailWidth int
42+
MaxThumbnailHeight int
4143
FullSizeQuality int
4244
MaxFullWidth int
4345
MaxFullHeight int

frontend/src/version.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ interface Change {
99
}
1010

1111
export const CHANGES: Change[] = [
12+
{
13+
name: '0.11.0',
14+
changes: [{ description: 'Configurable max thumbnail width and height', type: 'feature' }],
15+
},
1216
{
1317
name: '0.10.0',
1418
changes: [{ description: 'Preload images', type: 'feature' }],

0 commit comments

Comments
 (0)