Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Commit 082c0f8

Browse files
committed
trying to fix chromedp on GH action
1 parent 3957ce1 commit 082c0f8

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

.github/workflows/go.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ jobs:
1515

1616
- name: Install dependencies for chromedp
1717
run: sudo apt-get install -y libnspr4 libnss3 libexpat1 libfontconfig1 libuuid1
18-
19-
- name: Trying to have chromedp work
20-
run: sudo apt-get install -y chromium-browser
18+
2119

2220
- name: Start containers (PostgreSQL, MongoDB, Redis)
2321
run: docker-compose -f "docker-compose-unittest.yml" up -d

extras.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,16 +142,16 @@ func (ex *extras) htmlToX(w http.ResponseWriter, r *http.Request) {
142142
return
143143
}
144144

145-
/* trying to make GH action pass
146-
opts := append(chromedp.DefaultExecAllocatorOptions[:],
145+
/*opts := append(chromedp.DefaultExecAllocatorOptions[:],
147146
chromedp.Flag("disable-gpu", true),
148147
)*/
149148

150149
// make sure it can timeout
151-
cctx, _ := context.WithTimeout(context.Background(), 3*time.Second)
150+
//cctx, _ := context.WithTimeout(context.Background(), 3*time.Second)
152151

153-
//HACK: chromedp.NewExecAllocator(cctx, opts...)
154-
ctx, cancel := chromedp.NewContext(cctx)
152+
//HACK:
153+
//ctx, cancel := chromedp.NewContext(cctx)
154+
ctx, cancel := chromedp.NewContext(context.Background())
155155
defer cancel()
156156

157157
var buf []byte

0 commit comments

Comments
 (0)