Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit 23867bf

Browse files
committed
fix failing tesrs fixtures
(cherry picked from commit c3d5863)
1 parent 8bb9f08 commit 23867bf

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

spring-cloud-dataflow-configuration-metadata/src/test/java/org/springframework/cloud/dataflow/container/registry/DefaultContainerImageMetadataResolverTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
import java.util.HashMap;
2222
import java.util.Map;
2323

24+
import com.fasterxml.jackson.core.JsonProcessingException;
25+
import com.fasterxml.jackson.databind.ObjectMapper;
2426
import org.junit.Before;
2527
import org.junit.Test;
2628
import org.mockito.Mock;
@@ -96,7 +98,7 @@ public void getImageLabelsInvalidImageName() {
9698
}
9799

98100
@Test
99-
public void getImageLabels() {
101+
public void getImageLabels() throws JsonProcessingException {
100102

101103
DefaultContainerImageMetadataResolver resolver = new MockedDefaultContainerImageMetadataResolver(this.containerRegistryService);
102104

@@ -112,7 +114,7 @@ public void getImageLabels() {
112114
}
113115

114116
@Test
115-
public void getImageLabelsFromPrivateRepository() {
117+
public void getImageLabelsFromPrivateRepository() throws JsonProcessingException {
116118

117119
DefaultContainerImageMetadataResolver resolver = new MockedDefaultContainerImageMetadataResolver(this.containerRegistryService);
118120

@@ -129,10 +131,8 @@ public void getImageLabelsFromPrivateRepository() {
129131

130132
@Test(expected = ContainerRegistryException.class)
131133
public void getImageLabelsMissingRegistryConfiguration() {
132-
133134
DefaultContainerImageMetadataResolver resolver = new MockedDefaultContainerImageMetadataResolver(this.containerRegistryService);
134-
135-
resolver.getImageLabels("test/image:latest");
135+
resolver.getImageLabels("somehost:8083/test/image:latest");
136136
}
137137

138138
@Test(expected = ContainerRegistryException.class)
@@ -183,7 +183,7 @@ public void getImageLabelsInvalidDigest() {
183183
}
184184

185185
@Test
186-
public void getImageLabelsWithInvalidLabels() {
186+
public void getImageLabelsWithInvalidLabels() throws JsonProcessingException {
187187

188188
DefaultContainerImageMetadataResolver resolver = new MockedDefaultContainerImageMetadataResolver(this.containerRegistryService);
189189

@@ -217,7 +217,7 @@ private void mockManifestRestTemplateCall(Map<String, Object> mapToReturn, Strin
217217
}
218218

219219
private void mockBlogRestTemplateCall(String jsonResponse, String registryHost, String registryPort,
220-
String repository, String digest) {
220+
String repository, String digest) throws JsonProcessingException {
221221

222222
UriComponents blobUriComponents = UriComponentsBuilder.newInstance()
223223
.scheme("https")
@@ -230,8 +230,8 @@ private void mockBlogRestTemplateCall(String jsonResponse, String registryHost,
230230
eq(blobUriComponents.toUri()),
231231
eq(HttpMethod.GET),
232232
any(HttpEntity.class),
233-
eq(String.class)))
234-
.thenReturn(new ResponseEntity<>(jsonResponse, HttpStatus.OK));
233+
eq(Map.class)))
234+
.thenReturn(new ResponseEntity<>(new ObjectMapper().readValue(jsonResponse, Map.class), HttpStatus.OK));
235235
}
236236

237237
private class MockedDefaultContainerImageMetadataResolver extends DefaultContainerImageMetadataResolver {

0 commit comments

Comments
 (0)