Skip to content

fix: exact match for gz files in hash_sha256_verify #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

hatajoe
Copy link
Contributor

@hatajoe hatajoe commented Jul 15, 2025

Hi.

tfcmt v4.14.8 has .sbom.json files like tfcmt_linux_amd64.tar.gz.sbom.json.
ref: https://github.com/suzuki-shunsuke/tfcmt/releases

This cause following checksum verification error:

% bash install.sh
suzuki-shunsuke/tfcmt info checking GitHub for latest tag
suzuki-shunsuke/tfcmt info found version: 4.14.8 for v4.14.8/Linux/arm64
suzuki-shunsuke/tfcmt err hash_sha256_verify checksum for '/tmp/tmp.LhNBsXAyPC/tfcmt_linux_arm64.tar.gz' did not verify fb5a2a70f84c7ac2bf783587ad863a351435a81317a2a184e0d4d1a7e8dc0146
9037d0ab49cacc787f19f8158f95c3574630c11b962f592cd3d54f9921808413 vs fb5a2a70f84c7ac2bf783587ad863a351435a81317a2a184e0d4d1a7e8dc0146

I think we need exact match for the tar.gz file.

% bash install.sh
suzuki-shunsuke/tfcmt info checking GitHub for latest tag
suzuki-shunsuke/tfcmt info found version: 4.14.8 for v4.14.8/Linux/arm64
suzuki-shunsuke/tfcmt info installed ./bin/tfcmt

Could you review my change?
Thank you.

@hatajoe
Copy link
Contributor Author

hatajoe commented Jul 15, 2025

@shmokmt Sorry for taking your time. Would you mind taking a look when you have time?

@shmokmt shmokmt merged commit 04d5aa6 into shmokmt:main Jul 15, 2025
2 checks passed
@shmokmt
Copy link
Owner

shmokmt commented Jul 15, 2025

@hatajoe
v2.1.1 has been released.
Thanks!

@hatajoe hatajoe deleted the exact-match-for-gz branch July 16, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants