From bf1bba01999cbd2321114aeebdd4feaec1510d09 Mon Sep 17 00:00:00 2001 From: shmokmt <32533860+shmokmt@users.noreply.github.com> Date: Thu, 24 Oct 2024 08:27:57 +0900 Subject: [PATCH 1/2] It makes more sense to use Docker installed on your runner. --- script.sh | 8 -------- 1 file changed, 8 deletions(-) diff --git a/script.sh b/script.sh index c5173e9..6fd208a 100755 --- a/script.sh +++ b/script.sh @@ -8,14 +8,6 @@ export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}" TEMP_PATH="$(mktemp -d)" PATH="${TEMP_PATH}:$PATH" -# echo "::group:: Installing Docker..." -# # Re-install Docker Engine -# for pkg in docker.io docker-doc docker-compose docker-compose-v2 podman-docker containerd runc; do sudo apt-get remove $pkg; done -# # Install from official script -# curl -fsSL https://get.docker.com -o get-docker.sh -# sudo sh get-docker.sh -# echo "::endgroup" - echo "::group:: docker version" docker version echo "::endgroups::" From 22e43dea0a06b2814418e3644d5d4e019c680377 Mon Sep 17 00:00:00 2001 From: shmokmt <32533860+shmokmt@users.noreply.github.com> Date: Thu, 24 Oct 2024 08:42:37 +0900 Subject: [PATCH 2/2] Add a note section --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index c2cad4d..b8c41f0 100644 --- a/README.md +++ b/README.md @@ -31,5 +31,9 @@ jobs: github_token: ${{ secrets.github_token }} ``` +>[!NOTE] +> We recommend using Ubuntu, the GitHub self hosted runner. This action assumes that Docker and buildx are already installed on your system. If your runner does not have these pre-installed, please set them up yourself. + ## See Also * https://docs.docker.com/reference/build-checks/ +* https://github.com/actions/runner-images/