✨ Improve functions auto complete

Author: RTLS

assets/svelte/functions/Edit.svelte

@@ -82,7 +82,7 @@
   export let usedByConsumers: Consumer[] = [];
   export let initialCodeMap: Record<string, string>;
   export let functionTransformsEnabled: boolean;
-  export let functionCompletions: Array<{
+  export let completions: Array<{
     label: string;
     type: string;
     info: string;
@@ -218,7 +218,7 @@
 
     return {
       from: word.from,
-      options: [...variableCompletions, ...functionCompletions],
+      options: [...variableCompletions, ...completions],
     };
   };
 

lib/sequin_web/live/functions/auto_complete.ex

@@ -1,5 +1,6 @@
 defmodule SequinWeb.FunctionLive.AutoComplete do
   @moduledoc false
+  @reserved_words ~w(do if else end case cond for with fn)
   @function_completion_modules [
     Date,
     DateTime,
@@ -13,6 +14,14 @@ defmodule SequinWeb.FunctionLive.AutoComplete do
     Base
   ]
 
+  def all_completions do
+    reserved_completions() ++ function_completions()
+  end
+
+  def reserved_completions do
+    Enum.map(@reserved_words, &%{label: &1, type: "keyword"})
+  end
+
   def function_completions do
     Enum.flat_map(@function_completion_modules, &function_completions/1)
   end

lib/sequin_web/live/functions/edit.ex

@@ -216,7 +216,7 @@ defmodule SequinWeb.FunctionsLive.Edit do
 
   # We generate the function completions at compile time because
   # docs are not available at runtime in our release.
-  @function_completions AutoComplete.function_completions()
+  @all_completions AutoComplete.all_completions()
 
   @impl Phoenix.LiveView
   def mount(params, _session, socket) do
@@ -264,7 +264,7 @@ defmodule SequinWeb.FunctionsLive.Edit do
         selected_table_oid: nil,
         synthetic_test_message: Consumers.synthetic_message(),
         initial_code: @initial_code_map,
-        function_completions: @function_completions,
+        all_completions: @all_completions,
         function_transforms_enabled: Sequin.feature_enabled?(current_account_id(socket), :function_transforms)
       )
       |> assign_encoded_messages()
@@ -292,7 +292,7 @@ defmodule SequinWeb.FunctionsLive.Edit do
             initialCodeMap: @initial_code,
             initialCode: "glugma",
             functionTransformsEnabled: @function_transforms_enabled,
-            functionCompletions: @function_completions
+            completions: @all_completions
           }
         }
         socket={@socket}