Fix test and lint.

nachogiljaldo · nachogiljaldo · commit f74a1c8753b2 · 2024-11-15T17:35:33.000+01:00
diff --git a/reader.go b/reader.go
@@ -180,12 +180,11 @@ func (r *Reader) commitOffsetsWithRetry(gen *Generation, offsetStash offsetStash
 			// IllegalGeneration error is not retriable, but we should attempt to
 			// perform the remaining commits
 			if errors.Is(err, IllegalGeneration) {
-				r.withErrorLogger(func(l Logger) { l.Printf("%v", err) })
+				r.withErrorLogger(func(l Logger) { l.Printf("generation %d - %v", generationID, err) })
+				offsetStash.removeGenerationID(generationID)
 				illegalGenerationErr = true
 				err = nil
-				offsetStash.removeGenerationID(generationID)
 			}
-			return
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -180,12 +180,11 @@ func (r Reader) commitOffsetsWithRetry(gen Generation, offsetStash offsetStash`
`180`	`180`	`// IllegalGeneration error is not retriable, but we should attempt to`
`181`	`181`	`// perform the remaining commits`
`182`	`182`	`if errors.Is(err, IllegalGeneration) {`
`183`		`- r.withErrorLogger(func(l Logger) { l.Printf("%v", err) })`
	`183`	`+ r.withErrorLogger(func(l Logger) { l.Printf("generation %d - %v", generationID, err) })`
	`184`	`+ offsetStash.removeGenerationID(generationID)`
`184`	`185`	`illegalGenerationErr = true`
`185`	`186`	`err = nil`
`186`		`- offsetStash.removeGenerationID(generationID)`
`187`	`187`	`}`
`188`		`- return`
`189`	`188`	`}`
`190`	`189`	`}`
`191`	`190`