Skip to content

Commit 8d402b0

Browse files
authored
Merge pull request #288 from muzarski/compile-testing-conditionally
Compile `integration_testing.rs` conditionally
2 parents 3c28a13 + b3b551c commit 8d402b0

File tree

4 files changed

+18
-7
lines changed

4 files changed

+18
-7
lines changed

scylla-rust-wrapper/CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ else()
2727
set(CMAKE_Rust_FLAGS "--cfg cpp_rust_unstable")
2828
endif()
2929

30+
if(CASS_BUILD_INTEGRATION_TESTS)
31+
set(CMAKE_Rust_FLAGS "${CMAKE_Rust_FLAGS} --cfg cpp_integration_testing")
32+
endif()
33+
3034
if(APPLE)
3135
set(INSTALL_NAME_SHARED "libscylla-cpp-driver.${PROJECT_VERSION_STRING}.dylib")
3236
set(INSTALL_NAME_SHARED_SYMLINK_VERSION "libscylla-cpp-driver.${PROJECT_VERSION_MAJOR}.dylib")

scylla-rust-wrapper/Cargo.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,3 +60,6 @@ strip = "none"
6060

6161
[lints.rust]
6262
unsafe-op-in-unsafe-fn = "warn"
63+
unexpected_cfgs = { level = "warn", check-cfg = [
64+
'cfg(cpp_integration_testing)',
65+
] }

scylla-rust-wrapper/src/cluster.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ use crate::uuid::CassUuid;
1111
use openssl::ssl::SslContextBuilder;
1212
use openssl_sys::SSL_CTX_up_ref;
1313
use scylla::client::execution_profile::ExecutionProfileBuilder;
14-
use scylla::client::session::SessionConfig;
1514
use scylla::client::session_builder::SessionBuilder;
1615
use scylla::client::{SelfIdentity, WriteCoalescingDelay};
1716
use scylla::frame::Compression;
@@ -161,7 +160,16 @@ impl CassCluster {
161160
}
162161

163162
#[inline]
164-
pub(crate) fn get_session_config(&self) -> &SessionConfig {
163+
pub(crate) fn get_client_id(&self) -> Option<uuid::Uuid> {
164+
self.client_id
165+
}
166+
}
167+
168+
// Utilities for integration testing
169+
#[cfg(cpp_integration_testing)]
170+
impl CassCluster {
171+
#[inline]
172+
pub(crate) fn get_session_config(&self) -> &scylla::client::session::SessionConfig {
165173
&self.session_builder.config
166174
}
167175

@@ -174,11 +182,6 @@ impl CassCluster {
174182
pub(crate) fn get_contact_points(&self) -> &[String] {
175183
&self.contact_points
176184
}
177-
178-
#[inline]
179-
pub(crate) fn get_client_id(&self) -> Option<uuid::Uuid> {
180-
self.client_id
181-
}
182185
}
183186

184187
impl FFI for CassCluster {

scylla-rust-wrapper/src/lib.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ pub mod execution_error;
2121
mod external;
2222
pub mod future;
2323
pub mod inet;
24+
#[cfg(cpp_integration_testing)]
2425
pub mod integration_testing;
2526
pub mod iterator;
2627
mod logging;

0 commit comments

Comments
 (0)