enhance sles16 saptune handling and update pattern name

Author: marcelmamula

roles/sap_general_preconfigure/tasks/SLES/generic/saptune_takeover.yml

@@ -2,6 +2,7 @@
 ---
 # 1275776 - Linux: Preparing SLES for SAP environments
 
+# saptune_check fails if 'saptune service takeover' was not executed.
 - name: Execute saptune_check - before takeover
   ansible.builtin.command:
     cmd: saptune_check
@@ -10,10 +11,12 @@
   changed_when: false
   failed_when: false
 
-- name: Takeover and enable saptune
+- name: Takeover saptune
   when:
     - __sap_general_preconfigure_use_saptune
     - __sap_general_preconfigure_register_saptune_check_before.rc != 0
+    # sapconf is not present on SLES 16 and takeover is not required.
+    - ansible_distribution_major_version | int < 16
   block:
     - name: Check saptune version  # noqa: command-instead-of-module
       ansible.builtin.command:
@@ -27,7 +30,7 @@
         name: sapconf
         state: stopped
         enabled: false
-      when: __sap_general_preconfigure_register_sapconf
+      when: __sap_general_preconfigure_register_sapconf.rc == 0
 
     - name: Make sure that sapconf and tuned are stopped and disabled
       ansible.builtin.command:
@@ -42,13 +45,21 @@
       register: __sap_general_preconfigure_register_sapconf_failed
       changed_when: false
       ignore_errors: true
+      when: __sap_general_preconfigure_register_sapconf.rc == 0
 
     - name: Execute systemctl reset-failed sapconf.service  # noqa command-instead-of-module
       ansible.builtin.command:
         cmd: systemctl reset-failed sapconf.service
-      when: __sap_general_preconfigure_register_sapconf_failed.rc == 0
+      when:
+        - __sap_general_preconfigure_register_sapconf.rc == 0
+        - __sap_general_preconfigure_register_sapconf_failed.rc == 0
       changed_when: true
 
+
+- name: Enable saptune service
+  when:
+    - __sap_general_preconfigure_use_saptune
+  block:
     - name: Ensure saptune is running and enabled
       ansible.builtin.systemd:
         name: saptune

roles/sap_general_preconfigure/vars/SLES_SAP_16.yml

@@ -6,7 +6,7 @@
 __sap_general_preconfigure_sapnotes_versions: []
 
 __sap_general_preconfigure_patterns:
-  - sles_minimal_sap
+  - sles_sap_minimal_sap
 
 __sap_general_preconfigure_packages:
   # Patterns are not included in package list

roles/sap_hana_preconfigure/tasks/SLES/generic/saptune_takeover.yml

@@ -10,10 +10,12 @@
   changed_when: false
   failed_when: false
 
-- name: Takeover and enable saptune
+- name: Takeover saptune
   when:
     - __sap_hana_preconfigure_use_saptune
     - __sap_hana_preconfigure_register_saptune_check_before.rc != 0
+    # sapconf is not present on SLES 16 and takeover is not required.
+    - ansible_distribution_major_version | int < 16
   block:
     - name: Check saptune version  # noqa: command-instead-of-module
       ansible.builtin.command:
@@ -27,7 +29,7 @@
         name: sapconf
         state: stopped
         enabled: false
-      when: __sap_hana_preconfigure_register_sapconf
+      when: __sap_hana_preconfigure_register_sapconf.rc == 0
 
     - name: Make sure that sapconf and tuned are stopped and disabled
       ansible.builtin.command:
@@ -49,6 +51,11 @@
       when: __sap_hana_preconfigure_register_sapconf_failed.rc == 0
       changed_when: true
 
+
+- name: Enable saptune service
+  when:
+    - __sap_hana_preconfigure_use_saptune
+  block:
     - name: Ensure saptune is running and enabled
       ansible.builtin.systemd:
         name: saptune

roles/sap_hana_preconfigure/vars/SLES_SAP_16.yml

@@ -4,11 +4,13 @@
 # - SUSE Linux Enterprise Server for SAP Applications 16
 
 __sap_hana_preconfigure_sapnotes_versions: []
+  # 3577842 - - SAP HANA DB: Recommended OS settings for SLES 16 / SLES for SAP Applications 16
+  # - { number: '3577842', version: '1' }
 
 __sap_hana_preconfigure_min_pkgs:
 
 __sap_hana_preconfigure_patterns:
-  - sles_minimal_sap
+  - sles_sap_minimal_sap
   - sles_sap_DB
 
 __sap_hana_preconfigure_packages:
@@ -24,6 +26,9 @@ __sap_hana_preconfigure_packages:
   - sysstat
   - sysctl-logger
 
+  # 3577842
+  - libltdl7
+
   # 3139184 - Linux: systemd integration for sapstartsrv and SAP Host Agent
   - polkit
 

roles/sap_netweaver_preconfigure/tasks/SLES/generic/saptune_takeover.yml

@@ -10,10 +10,12 @@
   changed_when: false
   failed_when: false
 
-- name: Takeover and enable saptune
+- name: Takeover saptune
   when:
     - __sap_netweaver_preconfigure_use_saptune
     - __sap_netweaver_preconfigure_register_saptune_check_before.rc != 0
+    # sapconf is not present on SLES 16 and takeover is not required.
+    - ansible_distribution_major_version | int < 16
   block:
     - name: Check saptune version  # noqa: command-instead-of-module
       ansible.builtin.command:
@@ -27,7 +29,7 @@
         name: sapconf
         state: stopped
         enabled: false
-      when: __sap_netweaver_preconfigure_register_sapconf
+      when: __sap_netweaver_preconfigure_register_sapconf.rc == 0
 
     - name: Make sure that sapconf and tuned are stopped and disabled
       ansible.builtin.command:
@@ -49,6 +51,11 @@
       when: __sap_netweaver_preconfigure_register_sapconf_failed.rc == 0
       changed_when: true
 
+
+- name: Enable saptune service
+  when:
+    - __sap_netweaver_preconfigure_use_saptune
+  block:
     - name: Ensure saptune is running and enabled
       ansible.builtin.systemd:
         name: saptune

roles/sap_netweaver_preconfigure/vars/SLES_SAP_16.yml

@@ -6,7 +6,7 @@
 __sap_netweaver_preconfigure_sapnotes_versions: []
 
 __sap_netweaver_preconfigure_patterns:
-  - sles_minimal_sap
+  - sles_sap_minimal_sap
   - sles_sap_APP
 
 __sap_netweaver_preconfigure_packages: