feat: removed dependencies on ansible_facts.packages

Author: marcelmamula

roles/sap_general_preconfigure/tasks/RedHat/assert-configuration.yml

@@ -1,6 +1,11 @@
 # SPDX-License-Identifier: Apache-2.0
 ---
 
+- name: Gather package facts again after the installation phase
+  ansible.builtin.package_facts:
+  tags:
+    - always
+
 - name: Assert - List required SAP Notes
   ansible.builtin.debug:
     var: __sap_general_preconfigure_sapnotes_versions | difference([''])

roles/sap_general_preconfigure/tasks/RedHat/assert-installation.yml

@@ -1,6 +1,11 @@
 # SPDX-License-Identifier: Apache-2.0
 ---
 
+- name: Gather package facts
+  ansible.builtin.package_facts:
+  tags:
+    - sap_general_preconfigure_installation
+
 - name: Check enabled repos
   when: sap_general_preconfigure_enable_repos
   block:

roles/sap_general_preconfigure/tasks/RedHat/configuration.yml

@@ -1,6 +1,11 @@
 # SPDX-License-Identifier: Apache-2.0
 ---
 
+- name: Gather package facts again after the installation phase
+  ansible.builtin.package_facts:
+  tags:
+    - always
+
 - name: Configure - List required SAP Notes
   ansible.builtin.debug:
     var: __sap_general_preconfigure_sapnotes_versions | difference([''])

roles/sap_general_preconfigure/tasks/RedHat/installation.yml

@@ -1,6 +1,11 @@
 # SPDX-License-Identifier: Apache-2.0
 ---
 
+- name: Gather package facts
+  ansible.builtin.package_facts:
+  tags:
+    - sap_general_preconfigure_installation
+
 - name: Perform steps for enabling required repos
   when: sap_general_preconfigure_enable_repos
   block:

roles/sap_general_preconfigure/tasks/SLES/assert-installation.yml

@@ -1,49 +1,86 @@
 # SPDX-License-Identifier: Apache-2.0
 ---
 
-- name: Get list of what provides packages  # noqa command-instead-of-module
-  ansible.builtin.command:
-    cmd: "rpm -q --whatprovides {{ item }}"
-  register: __sap_general_preconfigure_register_whatprovides
+# Both sap_general_preconfigure_packages and __sap_general_preconfigure_min_pkgs are checked at same time.
+# Check rpm --whatprovides only if package cannot be found directly.
+- name: Query RPM packages
+  ansible.builtin.shell:
+    cmd: |
+      if rpm -q {{ item }} &> /dev/null;
+      then rpm -q {{ item }}
+      else rpm -q --whatprovides {{ item }};
+      fi
+  register: __sap_general_preconfigure_register_packages
   changed_when: false
   ignore_errors: true
-  loop: "{{ sap_general_preconfigure_packages }}"
+  loop: "{{ sap_general_preconfigure_packages if not sap_general_preconfigure_min_package_check | bool
+    else ((sap_general_preconfigure_packages | d([])) + (__sap_general_preconfigure_min_pkgs | d([])) | map(attribute='0') | unique) }}"
 
 
-# Both sap_general_preconfigure_packages and __sap_general_preconfigure_min_pkgs are checked at same time.
 - name: Assert that all required packages are installed
   ansible.builtin.assert:
-    that: item in ansible_facts.packages
-      or __sap_general_preconfigure_register_whatprovides.results | selectattr('item', 'equalto', item) | map(attribute='rc') | first == 0
+    that: __sap_general_preconfigure_register_packages.results | selectattr('item', 'equalto', item) | map(attribute='rc') | first == 0
     fail_msg: "FAIL: Package '{{ item }}' is not installed!"
     success_msg: "PASS: Package '{{ item }}' is installed."
   loop: "{{ sap_general_preconfigure_packages if not sap_general_preconfigure_min_package_check | bool
     else ((sap_general_preconfigure_packages | d([])) + (__sap_general_preconfigure_min_pkgs | d([])) | map(attribute='0') | unique) }}"
   ignore_errors: "{{ sap_general_preconfigure_assert_ignore_errors | d(false) }}"
 
 
-# Availability of minimum packages is checked above.
-- name: Assert that all minimum required packages are installed with minimum version
-  ansible.builtin.assert:
-    that:
-      - __version is version(item[1], '>=')
-    fail_msg: "FAIL: Minimum package version '{{ item[0] }}-{{ item[1] }}' is not installed! Current version: '{{ __version }}'"
-    success_msg: "PASS: Minimum package version '{{ item[0] }}-{{ item[1] }}' is installed."
-  vars:
-    __version: "{{ ansible_facts.packages[item[0]][0]['version'] ~ '-' ~ ansible_facts.packages[item[0]][0]['release']
-      ~ '.' ~ ansible_facts.packages[item[0]][0]['arch']}}"
-  loop: "{{ __sap_general_preconfigure_min_pkgs }}"
+- name: Block for minimum required packages assert
   when:
     - sap_general_preconfigure_min_package_check | bool
     - __sap_general_preconfigure_min_pkgs | d([])
-  ignore_errors: "{{ sap_general_preconfigure_assert_ignore_errors | d(false) }}"
+  block:
+    - name: Query RPM packages for minimum required packages
+      ansible.builtin.shell:
+        cmd: |
+          if rpm -q {{ item[0] }} &> /dev/null;
+          then rpm -q --queryformat '%{VERSION}-%{RELEASE}.%{ARCH}\n' {{ item[0] }}
+          else rpm -q --queryformat '%{VERSION}-%{RELEASE}.%{ARCH}\n' --whatprovides {{ item[0] }};
+          fi
+      register: __sap_general_preconfigure_register_packages_minimum
+      changed_when: false
+      ignore_errors: true
+      loop: "{{ __sap_general_preconfigure_min_pkgs }}"
 
 
+    - name: Assert that all minimum required packages are installed with minimum version
+      ansible.builtin.assert:
+        that:
+          - __version[0] is version(item[1], '>=')
+        fail_msg: "FAIL: Minimum package version '{{ item[0] }}-{{ item[1] }}' is not installed! Current version: '{{ __version[0] }}'"
+        success_msg: "PASS: Minimum package version '{{ item[0] }}-{{ item[1] }}' is installed."
+      vars:
+        __version:
+          "{{ __sap_general_preconfigure_register_packages_minimum.results | selectattr('item', 'equalto', item) | map(attribute='stdout') }}"
+      loop: "{{ __sap_general_preconfigure_min_pkgs }}"
+      ignore_errors: "{{ sap_general_preconfigure_assert_ignore_errors | d(false) }}"
+      when: __sap_general_preconfigure_register_packages.results | selectattr('item', 'equalto', item[0]) | map(attribute='rc') | first == 0
+
+
+- name: Gather service facts
+  ansible.builtin.service_facts:
+
+# Service packagekit is part of PackageKit-backend-zypp (SLE-Module-Desktop-Applications)
+# This service creates zypper locks and causes package install failures.
+- name: Wait for stop of packagekit.service
+  ansible.builtin.shell: |
+    set -o pipefail && bash -c '
+    while (ps aux | grep "[z]ypper" | grep -v grep) || (ps aux | grep "/usr/lib/packagekitd" | grep -v grep) ||
+     ([ -f /var/run/zypp.pid ] && [ -s /var/run/zypp.pid ]); do
+      sleep 10;
+    done'
+  register: __packagekit_service_check
+  changed_when: false
+  until: __packagekit_service_check.rc == 0
+  retries: 60
+  when: "'packagekit.service' in ansible_facts.services"
+
 - name: Get info about possible package updates # noqa command-instead-of-module
   ansible.builtin.command:
     cmd: zypper -q patch-check
-  timeout: 120
-  retries: 5
+  timeout: 60
   register: __sap_general_preconfigure_register_zypper_check_update_assert
   changed_when: false
   ignore_errors: true  # true, because unpatched system is always error.
@@ -81,13 +118,24 @@
   ignore_errors: "{{ sap_general_preconfigure_assert_ignore_errors | d(false) }}"
 
 
-- name: Assert saptune is at requested version
-  ansible.builtin.assert:
-    that: ansible_facts.packages['saptune'][0]['version'] == sap_general_preconfigure_saptune_version
-    fail_msg: "FAIL: saptune version installed is {{ ansible_facts.packages['saptune'][0]['version']
-      }} but the version {{ sap_general_preconfigure_saptune_version }} was expected"
-    success_msg: "PASS: the installed version of saptune meets the expected version: {{ sap_general_preconfigure_saptune_version }}"
+- name: Block to assert that correct saptune version is installed
   when:
     - __sap_general_preconfigure_use_saptune
     - sap_general_preconfigure_saptune_version is defined
     - sap_general_preconfigure_saptune_version | length > 0
+  block:
+    # We are checking for %{VERSION} (e.g. 3.1.4), not full %{VERSION}-%{RELEASE}.%{ARCH}
+    - name: Check saptune version  # noqa: command-instead-of-module
+      ansible.builtin.command:
+        cmd: rpm -q --queryformat '%{VERSION}\n' saptune
+      register: __sap_general_preconfigure_register_saptune_version
+      changed_when: false
+      ignore_errors: true
+
+    - name: Assert saptune is at requested version
+      ansible.builtin.assert:
+        that: __sap_general_preconfigure_register_saptune_version.stdout == sap_general_preconfigure_saptune_version
+        fail_msg: "FAIL: saptune version installed is {{ __sap_general_preconfigure_register_saptune_version.stdout
+          }} but the version {{ sap_general_preconfigure_saptune_version }} was expected"
+        success_msg: "PASS: the installed version of saptune meets the expected version: {{ sap_general_preconfigure_saptune_version }}"
+      when: __sap_general_preconfigure_register_saptune_version.rc == 0

roles/sap_general_preconfigure/tasks/SLES/generic/saptune_takeover.yml

@@ -15,12 +15,19 @@
     - __sap_general_preconfigure_use_saptune
     - __sap_general_preconfigure_register_saptune_check_before.rc != 0
   block:
+    - name: Check saptune version  # noqa: command-instead-of-module
+      ansible.builtin.command:
+        cmd: rpm -q sapconf
+      register: __sap_general_preconfigure_register_sapconf
+      changed_when: false
+      ignore_errors: true
+
     - name: Ensure sapconf is stopped and disabled
       ansible.builtin.systemd:
         name: sapconf
         state: stopped
         enabled: false
-      when: "'sapconf' in ansible_facts.packages"
+      when: __sap_general_preconfigure_register_sapconf
 
     - name: Make sure that sapconf and tuned are stopped and disabled
       ansible.builtin.command:

roles/sap_general_preconfigure/tasks/SLES/installation.yml

@@ -1,6 +1,17 @@
 # SPDX-License-Identifier: Apache-2.0
 ---
 
+# Requirement for package_facts Ansible Module
+- name: Ensure OS Package for Python Lib of rpm bindings is enabled for System Python
+  ansible.builtin.package:
+    name: python3-rpm
+    state: present
+
+- name: Gather package facts
+  ansible.builtin.package_facts:
+  tags:
+    - sap_general_preconfigure_installation
+
 - name: Gather service facts
   ansible.builtin.service_facts:
 

roles/sap_general_preconfigure/tasks/main.yml

@@ -106,19 +106,6 @@
   tags:
     - always
 
-# Requirement for package_facts Ansible Module
-- name: For SLES ensure OS Package for Python Lib of rpm bindings is enabled for System Python
-  ansible.builtin.package:
-    name: python3-rpm
-    state: present
-  when: ansible_os_family == "Suse"
-
-# required for installation and configuration tasks:
-- name: Gather package facts
-  ansible.builtin.package_facts:
-  tags:
-    - sap_general_preconfigure_installation
-
 - name: Include tasks from 'installation.yml'
   ansible.builtin.include_tasks:
     file: '{{ item }}/{{ __sap_general_preconfigure_fact_assert_filename_prefix }}installation.yml'
@@ -132,11 +119,6 @@
   tags:
     - sap_general_preconfigure_installation
 
-- name: Gather package facts again after the installation phase
-  ansible.builtin.package_facts:
-  tags:
-    - always
-
 - name: Include tasks from 'configuration.yml'
   ansible.builtin.include_tasks:
     file: '{{ item }}/{{ __sap_general_preconfigure_fact_assert_filename_prefix }}configuration.yml'

roles/sap_general_preconfigure/tasks/sapnote/2578899/assert-configuration.yml

@@ -57,13 +57,14 @@
   block:
 
     - name: Gather kernel parameters
-      ansible.builtin.setup:
-        filter: ansible_kernel
+      ansible.builtin.command: sysctl kernel.pid_max
+      register: __sap_general_preconfigure_register_pid_max
+      changed_when: false
 
     - name: Assert that kernel parameter pid_max is set to 4194304
       ansible.builtin.assert:
         that:
-          - "ansible_kernel.sysctl['kernel.pid_max'] == '4194304'"
+          - "__sap_general_preconfigure_register_pid_max.stdout.split('=')[1] | trim == '4194304'"
         fail_msg: "FAIL: Kernel parameter kernel.pid_max is not set to 4194304!"
         success_msg: "PASS: Kernel parameter kernel.pid_max is set to 4194304."
       ignore_errors: "{{ sap_general_preconfigure_assert_ignore_errors | d(false) }}"

roles/sap_general_preconfigure/tasks/sapnote/2578899/assert-installation.yml

@@ -1,17 +1,22 @@
 # SPDX-License-Identifier: Apache-2.0
 ---
 
-- name: Get list of what provides packages  # noqa command-instead-of-module
-  ansible.builtin.command:
-    cmd: "rpm -q --whatprovides {{ item }}"
-  register: __sap_general_preconfigure_register_whatprovides
+# Check rpm --whatprovides only if package cannot be found directly.
+- name: Query RPM packages
+  ansible.builtin.shell:
+    cmd: |
+      if rpm -q {{ item }} &> /dev/null;
+      then rpm -q {{ item }}
+      else rpm -q --whatprovides {{ item }};
+      fi
+  register: __sap_general_preconfigure_register_packages
   changed_when: false
+  ignore_errors: true
   loop: "{{ __sap_general_preconfigure_packages_2578899 }}"
 
 - name: Assert that all required packages are installed
   ansible.builtin.assert:
-    that: item in ansible_facts.packages
-      or __sap_general_preconfigure_register_whatprovides.results | selectattr('item', 'equalto', item) | map(attribute='rc') | first == 0
+    that: __sap_general_preconfigure_register_packages.results | selectattr('item', 'equalto', item) | map(attribute='rc') | first == 0
     fail_msg: "FAIL: Package '{{ item }}' is not installed!"
     success_msg: "PASS: Package '{{ item }}' is installed."
   loop: "{{ __sap_general_preconfigure_packages_2578899 }}"