From 35c44ea84d4e363208b973bbcff11aaef0ba9568 Mon Sep 17 00:00:00 2001 From: Ketan Gupta Date: Wed, 28 May 2025 21:24:27 +0100 Subject: [PATCH] Remove experimental flag for Symbol.dispose --- crates/cli-support/src/js/mod.rs | 20 +++++++++---------- crates/cli-support/src/lib.rs | 3 --- .../explicit-resource-management/build.sh | 2 +- 3 files changed, 10 insertions(+), 15 deletions(-) diff --git a/crates/cli-support/src/js/mod.rs b/crates/cli-support/src/js/mod.rs index 3ba5be3a719..8996e9ee545 100644 --- a/crates/cli-support/src/js/mod.rs +++ b/crates/cli-support/src/js/mod.rs @@ -1193,16 +1193,14 @@ __wbg_set_wasm(wasm);" wasm_bindgen_shared::free_function(name), )); ts_dst.push_str(" free(): void;\n"); - if self.config.symbol_dispose { - dst.push_str( - " - [Symbol.dispose]() {{ - this.free(); - }} - ", - ); - ts_dst.push_str(" [Symbol.dispose](): void;\n"); - } + dst.push_str( + " + [Symbol.dispose]() {{ + this.free(); + }} + ", + ); + ts_dst.push_str(" [Symbol.dispose](): void;\n"); dst.push_str(&class.contents); ts_dst.push_str(&class.typescript); @@ -2724,7 +2722,7 @@ __wbg_set_wasm(wasm);" pub fn generate(&mut self) -> Result<(), Error> { self.prestore_global_import_identifiers()?; // conditionally override Symbol.dispose - if self.config.symbol_dispose && !self.aux.structs.is_empty() { + if !self.aux.structs.is_empty() { self.expose_symbol_dispose()?; } diff --git a/crates/cli-support/src/lib.rs b/crates/cli-support/src/lib.rs index a07f48306a1..ce4fa84b22c 100755 --- a/crates/cli-support/src/lib.rs +++ b/crates/cli-support/src/lib.rs @@ -39,7 +39,6 @@ pub struct Bindgen { multi_value: bool, encode_into: EncodeInto, split_linked_modules: bool, - symbol_dispose: bool, } pub struct Output { @@ -86,7 +85,6 @@ impl Bindgen { let externref = env::var("WASM_BINDGEN_ANYREF").is_ok() || env::var("WASM_BINDGEN_EXTERNREF").is_ok(); let multi_value = env::var("WASM_BINDGEN_MULTI_VALUE").is_ok(); - let symbol_dispose = env::var("WASM_BINDGEN_EXPERIMENTAL_SYMBOL_DISPOSE").is_ok(); Bindgen { input: Input::None, out_name: None, @@ -107,7 +105,6 @@ impl Bindgen { encode_into: EncodeInto::Test, omit_default_module_path: true, split_linked_modules: false, - symbol_dispose, } } diff --git a/examples/explicit-resource-management/build.sh b/examples/explicit-resource-management/build.sh index 0aecc1b2092..c7539bf3484 100755 --- a/examples/explicit-resource-management/build.sh +++ b/examples/explicit-resource-management/build.sh @@ -3,5 +3,5 @@ set -eux cargo build --target wasm32-unknown-unknown --release -WASM_BINDGEN_EXPERIMENTAL_SYMBOL_DISPOSE=1 cargo run --package wasm-bindgen-cli --bin wasm-bindgen -- \ +cargo run --package wasm-bindgen-cli --bin wasm-bindgen -- \ --out-dir pkg --target deno ${CARGO_TARGET_DIR:-../../target}/wasm32-unknown-unknown/release/explicit_resource_management.wasm