Makie plot is displayed twice in IJulia

[JamesWrigley]

With this code:

using DimensionalData
using CairoMakie

x = rand(100);

Running lines(x) in a cell creates one plot as expected, but lines(DimArray(x, (X(),))) displays the plot twice:

Not sure what could be going on there? 🤔 This is on Julia 1.12 RC1, DimensionalData 0.29.19, and CairoMakie 0.15.4.

[rafaqz]

Me either! What about in vscode or pluto?

[DylanMMarques]

It seems that it opens always 2 figures with CairoMakie.

The issue is with this line:

DimensionalData.jl/ext/DimensionalDataMakie.jl

Line 80 in 6f945d5

display(fig)

I am not sure why I added the display here. I did a quick test and it seems to work fine without it. I can try to find some time in the next few days to run some additional tests and open a PR

[asinghvi17]

we are not doing anything special / different here from what Makie does

DimensionalData.jl/ext/DimensionalDataMakie.jl

Lines 74 to 84 in 6f945d5

	for p in (PlotTypes_1D..., PlotTypes_2D..., PlotTypes_3D..., Series, PlotTypes_Cat_1D...)
	f = Makie.plotkey(p)
	eval(quote
	function Makie.$f(A::MayObs{<:AbstractDimArray}; figure = (;), attributes...)
	fig = Figure(; figure...)
	ax, plt = $f(fig[1,1], A; attributes...)
	display(fig)
	return Makie.FigureAxisPlot(fig, ax, plt)
	end
	end)
	end

Why not just delete it?

[DylanMMarques]

You are right, I am just not sure why I put it there in the first place. I was probably testing a few things a then forgot to remove it. Deleting it is the right thing to do

[lazarusA]

Sometimes in glmakie we force the display, maybe that's why?

[rafaqz]

Yeah that display line shouldn't be there, let's delete