Merge pull request #14268 from rabbitmq/revert-14264-await-condition-for-exceptions

Revert "Handle exceptions in rabbit_ct_helpers:await_condition_with_retries/2 to continue waiting"

Author: michaelklishin

deps/rabbitmq_ct_helpers/src/rabbit_ct_helpers.erl

@@ -1130,16 +1130,12 @@ await_condition(ConditionFun, Timeout) ->
 await_condition_with_retries(_ConditionFun, 0) ->
     ct:fail("Condition did not materialize in the expected period of time");
 await_condition_with_retries(ConditionFun, RetriesLeft) ->
-    try ConditionFun() of
+    case ConditionFun() of
         false ->
             timer:sleep(50),
             await_condition_with_retries(ConditionFun, RetriesLeft - 1);
         true ->
             ok
-    catch
-        _:_ ->
-            timer:sleep(50),
-            await_condition_with_retries(ConditionFun, RetriesLeft - 1)
     end.
 
 %% Pass in any EUnit test object. Example: