Fix BaseExperiment.from_config when passed dictionary (backport #1579) (#1582)

Fixes #1577

Fixed erroneous `**dict` usage
<hr>This is an automatic backport of pull request #1579 done by
[Mergify](https://mergify.com).

Co-authored-by: Jude Alnas <jude.alnas@gmail.com>
Co-authored-by: Will Shanks <willshanks@us.ibm.com>

Author: 3 people

qiskit_experiments/framework/base_experiment.py

@@ -187,7 +187,7 @@ def config(self) -> ExperimentConfig:
     def from_config(cls, config: Union[ExperimentConfig, Dict]) -> "BaseExperiment":
         """Initialize an experiment from experiment config"""
         if isinstance(config, dict):
-            config = ExperimentConfig(**dict)
+            config = ExperimentConfig(**config)
         ret = cls(*config.args, **config.kwargs)
         if config.experiment_options:
             ret.set_experiment_options(**config.experiment_options)

qiskit_experiments/library/randomized_benchmarking/layer_fidelity.py

@@ -573,7 +573,7 @@ def _metadata(self):
     def from_config(cls, config: Union[ExperimentConfig, Dict]) -> "LayerFidelity":
         """Initialize an experiment from experiment config"""
         if isinstance(config, dict):
-            config = ExperimentConfig(**dict)
+            config = ExperimentConfig(**config)
         ret = cls(*config.args, **config.kwargs)
         if config.run_options:
             ret.set_run_options(**config.run_options)

qiskit_experiments/library/randomized_benchmarking/layer_fidelity_unitary.py

@@ -666,7 +666,7 @@ def _metadata(self):
     def from_config(cls, config: Union[ExperimentConfig, Dict]) -> "LayerFidelity":
         """Initialize an experiment from experiment config"""
         if isinstance(config, dict):
-            config = ExperimentConfig(**dict)
+            config = ExperimentConfig(**config)
         ret = cls(*config.args, **config.kwargs)
         if config.run_options:
             ret.set_run_options(**config.run_options)

releasenotes/notes/from-config-dict-6629c37d2572cfbc.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    A bug that prevented passing a ``dict`` to
+    :meth:`.BaseExperiment.from_config` from working has been fixed (`#1577
+    <https://github.com/qiskit-community/qiskit-experiments/issues/1577>`__).