Added strict types directive

shudd3r · shudd3r · commit a53f600063c9 · 2021-03-03T21:44:19.000+01:00
diff --git a/src/Exception/StreamResourceCallException.php b/src/Exception/StreamResourceCallException.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/Factory/RequestFactory.php b/src/Factory/RequestFactory.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/Factory/ResponseFactory.php b/src/Factory/ResponseFactory.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/Factory/ServerRequestFactory.php b/src/Factory/ServerRequestFactory.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/Factory/StreamFactory.php b/src/Factory/StreamFactory.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/Factory/UploadedFileFactory.php b/src/Factory/UploadedFileFactory.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/Factory/UriFactory.php b/src/Factory/UriFactory.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/MessageMethodsTrait.php b/src/MessageMethodsTrait.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/NonSAPIUploadedFile.php b/src/NonSAPIUploadedFile.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/Request.php b/src/Request.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/RequestMethodsTrait.php b/src/RequestMethodsTrait.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/Response.php b/src/Response.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/ServerData.php b/src/ServerData.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/ServerRequest.php b/src/ServerRequest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/StatusCodesTrait.php b/src/StatusCodesTrait.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/Stream.php b/src/Stream.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/UploadedFile.php b/src/UploadedFile.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/src/Uri.php b/src/Uri.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/Doubles/FakeStream.php b/tests/Doubles/FakeStream.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
@@ -91,7 +91,7 @@ public function isReadable(): bool
     public function read($length): string
     {
         $send = substr($this->stream, 0, $length);
-        $this->stream = substr($this->stream, $length);
+        $this->stream = substr($this->stream, $length) ?: '';
         return $send;
     }
 
diff --git a/tests/Doubles/FakeUploadedFile.php b/tests/Doubles/FakeUploadedFile.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/Factory/FactoriesTest.php b/tests/Factory/FactoriesTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/Fixtures/MessageMethodsClass.php b/tests/Fixtures/MessageMethodsClass.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/Fixtures/request-factory-functions.php b/tests/Fixtures/request-factory-functions.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/Fixtures/stream-functions.php b/tests/Fixtures/stream-functions.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/Fixtures/uploaded-file-functions.php b/tests/Fixtures/uploaded-file-functions.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/MessageMethodsTest.php b/tests/MessageMethodsTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
@@ -256,9 +256,7 @@ public function testWithAddedHeaderSettingInvalidHeaderName_ThrowsException($nam
     public function invalidHeaderNames(): array
     {
         return [
-            'null name'             => [null],
             'empty name'            => [''],
-            'not a string name'     => [23],
             'spaced name'           => ['header name'],
             'invalid name char "@"' => ['email@example']
         ];
diff --git a/tests/NonSAPIUploadedFileTest.php b/tests/NonSAPIUploadedFileTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/RequestTest.php b/tests/RequestTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/ResponseTest.php b/tests/ResponseTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/ServerDataTest.php b/tests/ServerDataTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/ServerRequestTest.php b/tests/ServerRequestTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
diff --git a/tests/StreamTest.php b/tests/StreamTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
@@ -403,7 +403,7 @@ private function stream($resource = null, $mode = null): Stream
 
         return $this->stream = is_resource($resource)
             ? new Stream($resource)
-            : Stream::fromResourceUri($resource, $mode);
+            : Stream::fromResourceUri($resource, $mode ?? 'r');
     }
 
     private function fileStream($mode = null, string $contents = ''): Stream
diff --git a/tests/UploadedFileTest.php b/tests/UploadedFileTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.
@@ -30,8 +30,8 @@ class UploadedFileTest extends TestCase
 
     public function tearDown(): void
     {
-        if (is_file($this->tempFile)) { unlink($this->tempFile); }
-        if (is_file($this->movedFile)) { unlink($this->movedFile); }
+        if (is_file($this->tempFile ?? '')) { unlink($this->tempFile); }
+        if (is_file($this->movedFile ?? '')) { unlink($this->movedFile); }
         $this->tempFile  = null;
         $this->movedFile = null;
 
diff --git a/tests/UriTest.php b/tests/UriTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 /*
  * This file is part of Polymorphine/Message package.

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<?php`
	`1`	`+<?php declare(strict_types=1);`
`2`	`2`
`3`	`3`	`/*`
`4`	`4`	`* This file is part of Polymorphine/Message package.`