style: Enforce mypy no-implicit-optional setting (#294)

Which has been introduced in `mypy==0.981` and make sure proper type
annotations for args / kwargs with default `None` values.

Author: playpauseandstop

examples/hobotnica/src/hobotnica/app.py

@@ -1,5 +1,5 @@
 from pathlib import Path
-from typing import List
+from typing import List, Union
 
 from aiohttp import web
 from aiohttp_middlewares import (
@@ -13,7 +13,9 @@
 
 
 def create_app(
-    argv: List[str] = None, *, settings: BaseSettings = None
+    argv: Union[List[str], None] = None,
+    *,
+    settings: Union[BaseSettings, None] = None,
 ) -> web.Application:
     if settings is None:
         settings = BaseSettings.from_environ()

examples/petstore/src/petstore/app.py

@@ -1,5 +1,5 @@
 from pathlib import Path
-from typing import List
+from typing import List, Union
 
 from aiohttp import web
 
@@ -9,7 +9,9 @@
 
 
 def create_app(
-    argv: List[str] = None, *, settings: Settings = None
+    argv: Union[List[str], None] = None,
+    *,
+    settings: Union[Settings, None] = None,
 ) -> web.Application:
     """Create aiohttp applicaiton for OpenAPI 3 Schema.
 

examples/simulations/src/simulations/app.py

@@ -1,6 +1,6 @@
 import copy
 from pathlib import Path
-from typing import List
+from typing import List, Union
 
 import yaml
 from aiohttp import web
@@ -15,7 +15,7 @@
 operations = OperationTableDef()
 
 
-def create_app(argv: List[str] = None) -> web.Application:
+def create_app(argv: Union[List[str], None] = None) -> web.Application:
     schema = yaml.load(
         (Path(__file__).parent / "openapi.yaml").read_bytes(),
         Loader=get_default_yaml_loader(),

examples/todobackend/src/todobackend/app.py

@@ -1,5 +1,5 @@
 from pathlib import Path
-from typing import AsyncIterator, List
+from typing import AsyncIterator, List, Union
 
 from aiohttp import web
 from aiohttp_middlewares import https_middleware
@@ -14,7 +14,9 @@
 
 
 def create_app(
-    argv: List[str] = None, *, settings: Settings = None
+    argv: Union[List[str], None] = None,
+    *,
+    settings: Union[Settings, None] = None,
 ) -> web.Application:
     if settings is None:
         settings = Settings.from_environ()

poetry.lock

@@ -1,3 +1,7 @@
+[build-system]
+requires = ["poetry-core>=1.0.0"]
+build-backend = "poetry.core.masonry.api"
+
 [tool.badabump]
 version_type = "semver"
 version_files = [
@@ -20,7 +24,7 @@ source = ["./src/"]
 
 [tool.coverage.report]
 exclude_lines = ["if TYPE_CHECKING:", "@overload"]
-omit = ["./src/rororo/annotations.py"]
+omit = ["./src/*/main.py", "./src/*/annotations.py"]
 fail_under = 95
 skip_covered = true
 show_missing = true
@@ -54,6 +58,7 @@ follow_imports = "normal"
 follow_imports_for_stubs = true
 ignore_missing_imports = false
 namespace_packages = true
+no_implicit_optional = true
 mypy_path = "./src/"
 python_executable = "./.venv/bin/python3"
 show_column_numbers = true
@@ -208,7 +213,3 @@ commands_pre =
     pyrsistent==0.16 \
     PyYAML==5.1
 """
-
-[build-system]
-requires = ["poetry-core>=1.0.0"]
-build-backend = "poetry.core.masonry.api"

pyproject.toml

@@ -28,17 +28,19 @@ class AddResourceFunc(Protocol):
     def __call__(
         self,
         url: str,
-        get: Handler = None,
+        get: Union[Handler, None] = None,
         *,
-        name: str = None,
+        name: Union[str, None] = None,
         **kwargs: Handler,
     ) -> web.Resource:
         ...
 
 
 @contextmanager
 def add_resource_context(
-    router: web.UrlDispatcher, url_prefix: str = None, name_prefix: str = None
+    router: web.UrlDispatcher,
+    url_prefix: Union[str, None] = None,
+    name_prefix: Union[str, None] = None,
 ) -> Iterator[AddResourceFunc]:
     """Context manager for adding resources for given router.
 
@@ -65,7 +67,11 @@ def add_resource_context(
     """
 
     def add_resource(
-        url: str, get: Handler = None, *, name: str = None, **kwargs: Handler
+        url: str,
+        get: Union[Handler, None] = None,
+        *,
+        name: Union[str, None] = None,
+        **kwargs: Handler,
     ) -> web.Resource:
         """Inner function to create resource and add necessary routes to it.
 

src/rororo/aio.py

@@ -83,7 +83,7 @@ def update_sentry_logging(
     logging_dict: DictStrAny,
     sentry_dsn: Optional[str],
     *loggers: str,
-    level: Union[str, int] = None,
+    level: Union[str, int, None] = None,
     **kwargs: Any,
 ) -> None:
     r"""Enable Sentry logging if Sentry DSN passed.

src/rororo/logger.py

@@ -1,11 +1,36 @@
-from typing import Any, Dict, List, Union
+from typing import Any, Dict, List, Tuple, Union
+
+from aiohttp_middlewares.annotations import (
+    ExceptionType,
+    Handler,
+    StrCollection,
+    UrlCollection,
+)
+from aiohttp_middlewares.error import Config as ErrorMiddlewareConfig
 
 from rororo.annotations import TypedDict
 
 
 SecurityDict = Dict[str, List[str]]
 
 
+class CorsMiddlewareKwargsDict(TypedDict, total=False):
+    allow_all: bool
+    origins: Union[UrlCollection, None]
+    urls: Union[UrlCollection, None]
+    expose_headers: Union[StrCollection, None]
+    allow_headers: StrCollection
+    allow_methods: StrCollection
+    allow_credentials: bool
+    max_age: Union[int, None]
+
+
+class ErrorMiddlewareKwargsDict(TypedDict, total=False):
+    default_handler: Handler
+    config: Union[ErrorMiddlewareConfig, None]
+    ignore_exceptions: Union[ExceptionType, Tuple[ExceptionType, ...], None]
+
+
 class ValidateEmailKwargsDict(TypedDict, total=False):
     allow_smtputf8: bool
     allow_empty_local: bool

src/rororo/openapi/annotations.py

@@ -1,6 +1,6 @@
 from collections import deque
 from functools import partial
-from typing import Any, cast, Dict, Iterator, List, Optional, Tuple
+from typing import Any, cast, Dict, Iterator, List, Optional, Tuple, Union
 
 import pyrsistent
 from email_validator import EmailNotValidError, validate_email
@@ -86,7 +86,9 @@ class EmailFormatter(Formatter):
 
     kwargs: ValidateEmailKwargsDict
 
-    def __init__(self, kwargs: ValidateEmailKwargsDict = None) -> None:
+    def __init__(
+        self, kwargs: Union[ValidateEmailKwargsDict, None] = None
+    ) -> None:
         self.kwargs: ValidateEmailKwargsDict = kwargs or {
             "check_deliverability": False
         }
@@ -168,7 +170,7 @@ class SchemaUnmarshallersFactory(CoreSchemaUnmarshallersFactory):
     def get_formatter(
         self,
         default_formatters: Dict[str, Formatter],
-        type_format: str = None,
+        type_format: Union[str, None] = None,
     ) -> Formatter:
         if type_format == SchemaFormat.DATETIME.value:
             return DATE_TIME_FORMATTER
@@ -263,7 +265,7 @@ def _unmarshal(self, param_or_media_type: Any, value: Any) -> Any:  # type: igno
 
 
 def get_custom_formatters(
-    *, validate_email_kwargs: ValidateEmailKwargsDict = None
+    *, validate_email_kwargs: Union[ValidateEmailKwargsDict, None] = None
 ) -> Dict[str, Formatter]:
     return {"email": EmailFormatter(validate_email_kwargs)}
 
@@ -272,7 +274,7 @@ def validate_core_request(
     spec: Spec,
     core_request: OpenAPIRequest,
     *,
-    validate_email_kwargs: ValidateEmailKwargsDict = None,
+    validate_email_kwargs: Union[ValidateEmailKwargsDict, None] = None,
 ) -> Tuple[MappingStrAny, OpenAPIParameters, Any]:
     """
     Instead of validating request parameters & body in two calls, validate them
@@ -304,7 +306,7 @@ def validate_core_response(
     core_request: OpenAPIRequest,
     core_response: OpenAPIResponse,
     *,
-    validate_email_kwargs: ValidateEmailKwargsDict = None,
+    validate_email_kwargs: Union[ValidateEmailKwargsDict, None] = None,
 ) -> Any:
     """Pass custom formatters for validating response data."""
     custom_formatters = get_custom_formatters(