Update to Avalonia 11

[hendrikmennen]

Seems like this module is not as easy to port...

[VisualMelon]

hurried notes:

I took a jab at it in https://github.com/VisualMelon/oxyplot-avalonia/tree/av11

But the plots didn't render. I hard-coded something to do with invalidation to true and then they started flickering.

Something is wrong with the render invalidation, I believe, but the boring bits are done.

[hendrikmennen]

Thats where I got stuck too. Managed to make it "run" but never render. Don't really know the code so hard to know where to look

[VisualMelon]

Changing PlotBase.IsUserVisible to return element.IsEffectivelyVisible seems to make the simple demo work, but it disappears when you pan the plot (so a good back if you just need static plots).

[VisualMelon]

It's almost as if the old plot is being removed (by Canvas.Clear()) before the redraw, but the new plot isn't being added before the redraw (if you remove the clear, then not only do you get fun patterns, but there is no flickering).

[hendrikmennen]

Changing PlotBase.IsUserVisible to return element.IsEffectivelyVisible seems to make the simple demo work, but it disappears when you pan the plot (so a good back if you just need static plots).

Interesting. For me even panning works with a dynamic plot using this hack

[VisualMelon]

Are you able to share your repo? Might be that you've fixed something else that I've missed.

[hendrikmennen]

I discarded my repo and used yours. Directly with my project, let me try the demos
https://github.com/HendrikMennen/oxyplot-avalonia/tree/avalonia11

[hendrikmennen]

Are you able to share your repo? Might be that you've fixed something else that I've missed.

I think the flickering is solved by using Avalonia preview2

[VisualMelon]

Cool, will try it out now. I fixed the ExampleBrowser so it works in 11 in my repo.

[VisualMelon]

Yep, everything seems to be OK now. Still had to remove the bounds check in PlotBase.IsUserVisible, so may be other issues with that down the line.

[jp2masa]

This check is also broken:

https://github.com/VisualMelon/oxyplot-avalonia/blob/d4b0b66411f41b11384bb50aaf035b1e86ecefe3/Source/OxyPlot.Avalonia/PlotBase.cs#L104

I think TransformedBounds now returns null when there's no transform, so a possible solution is to do this (while still keeping the one for transformed bounds I think):

            this.GetObservable(BoundsProperty).Subscribe(bounds => OnSizeChanged(this, bounds.Size));

Even after that fix it doesn't always update: isUpdateRequired is stuck with value 2, not sure what's supposed to happen in order to reset it. This loop never runs again:

https://github.com/VisualMelon/oxyplot-avalonia/blob/d4b0b66411f41b11384bb50aaf035b1e86ecefe3/Source/OxyPlot.Avalonia/PlotBase.cs#L238

Also, may I ask what are the plans for the update, i.e. will there be a version for Avalonia 11 preview or only for the stable release? I have some time available to contribute if needed!

[VisualMelon]

Also, may I ask what are the plans for the update, i.e. will there be a version for Avalonia 11 preview or only for the stable release? I have some time available to contribute if needed!

There are no plans at the moment; I can't remember if I have rights to public releases, but if I do then I probably should sooner rather than later. Regarding 11, I'm not sure. Would need to look into it more to find out if we should be switching to 11, or if we need to keep it in parallel. (May be that we do 2.1 release with 10, then switch to 11 for the pre-release, in expectation that the next version is 11 only)

[K-Luth]

Is there an update on avalonia 11 support? I'm looking into upgrading my projects to avalonia and I'd like to use oxyplot.

[VisualMelon]

@K-Luth sorry for the slow reply; still no specific plan (will depend on when 11 is release), but I think we have a working branch targeting 11-preview4 (though still not sure what's up with IsUserVisible): https://github.com/VisualMelon/oxyplot-avalonia/tree/av11 - pre-release package at https://www.myget.org/feed/melonoxyplottesting/package/nuget/OxyPlot.Avalonia/2.1.0-av11 (but you shouldn't consider that feed reliable)

(2.1.0 was released a while back targeting Avalonia 10)

---

Update
Looks like there is an issue with updating when resized.

[jp2masa]

Sorry for not replying earlier.

Preview 5 was released yesterday and will likely be the last preview (AvaloniaUI/Avalonia#10193 (reply in thread)).

Looks like there is an issue with updating when resized.

This is the issue I was trying to describe in my previous comment. TransformedBounds will probably be replaced soon because it's broken (AvaloniaUI/Avalonia#9308 (comment)). Anyway, I believe PlotBase doesn't need it, and Bounds can be used for now, although using ArrangeOverride would probably work too, not sure because I honestly couldn't understand the isUpdateRequired logic.