Skip to content

Once more bpls fix #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

eisenhauer
Copy link
Member

Roll back previous incorrect fix, try to fix locally.

@eisenhauer eisenhauer requested a review from pnorbert March 31, 2025 17:51
@eisenhauer
Copy link
Member Author

@pnorbert Please take a look as I'm not entirely sure what some of the logic in bpls is meant to do...

Copy link
Contributor

@pnorbert pnorbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MinBlocksInfo should return information the same way as for GlobalArrays, since a joined array is presented as GlobalArray to a reader, without any differentiation to its origin.

@eisenhauer
Copy link
Member Author

The challenge here is that to do this properly the MinVarInfo semantics need to change a bit. Currently the Shape pointer in the MinVarInfo struct is a simple pointer to memory that is not owned by the struct. I.E. it can only point to an existing Shape value somewhere in the BP5 metadata (memory for which is managed separately). For GlobalArrays that were originally LocalValues or JoinedArray, we're constructing a new Shape value that doesn't exist elsewhere in the per-rank metadata, so to make sure that gets free'd properly we need to pass ownership of that memory back with the MinVarInfo struct. So it needs to be a Dims vector or a smart pointer. This isn't a problem generally, because MinVarInfo isn't user-exposed, but it pretty certainly violates the ABI stability requirements for minor releases, so it does mean that this fix waits for a major release...

@eisenhauer eisenhauer force-pushed the JoinedBPLS branch 3 times, most recently from 573c161 to 01118b5 Compare April 3, 2025 21:19
@eisenhauer eisenhauer enabled auto-merge (squash) April 3, 2025 21:20
@eisenhauer eisenhauer requested a review from pnorbert April 3, 2025 21:20
@eisenhauer eisenhauer disabled auto-merge April 3, 2025 23:32
@eisenhauer
Copy link
Member Author

@pnorbert please review. The failures here aren't related to this PR. (Still another race condition in shutdown I need to investigate.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants