Missing returns

eisenhauer · eisenhauer · commit 4591f6ad2f95 · 2025-04-03T18:51:03.000-04:00
diff --git a/source/adios2/toolkit/sst/cp/cp_writer.c b/source/adios2/toolkit/sst/cp/cp_writer.c
@@ -2535,6 +2535,7 @@ void CP_ReaderRequestStepHandler(CManager cm, CMConnection conn, void *Msg_v, vo
     {
         CP_verbose(Stream, TraceVerbose, "In RequestStepHandler, stream closing, ignore\n");
         STREAM_MUTEX_UNLOCK(CP_WSR_Stream->ParentStream);
+        return;
     }
     int RequestingReader = -1;
     for (int i = 0; i < Stream->ReaderCount; i++)
@@ -2549,6 +2550,7 @@ void CP_ReaderRequestStepHandler(CManager cm, CMConnection conn, void *Msg_v, vo
         CP_verbose(Stream, TraceVerbose,
                    "In RequestStepHandler, RequestingReader not found, ignore\n");
         STREAM_MUTEX_UNLOCK(CP_WSR_Stream->ParentStream);
+        return;
     }
 
     while (List)

Original file line number	Diff line number	Diff line change
`@@ -2535,6 +2535,7 @@ void CP_ReaderRequestStepHandler(CManager cm, CMConnection conn, void *Msg_v, vo`
`2535`	`2535`	`{`
`2536`	`2536`	`CP_verbose(Stream, TraceVerbose, "In RequestStepHandler, stream closing, ignore\n");`
`2537`	`2537`	`STREAM_MUTEX_UNLOCK(CP_WSR_Stream->ParentStream);`
	`2538`	`+ return;`
`2538`	`2539`	`}`
`2539`	`2540`	`int RequestingReader = -1;`
`2540`	`2541`	`for (int i = 0; i < Stream->ReaderCount; i++)`
`@@ -2549,6 +2550,7 @@ void CP_ReaderRequestStepHandler(CManager cm, CMConnection conn, void *Msg_v, vo`
`2549`	`2550`	`CP_verbose(Stream, TraceVerbose,`
`2550`	`2551`	`"In RequestStepHandler, RequestingReader not found, ignore\n");`
`2551`	`2552`	`STREAM_MUTEX_UNLOCK(CP_WSR_Stream->ParentStream);`
	`2553`	`+ return;`
`2552`	`2554`	`}`
`2553`	`2555`
`2554`	`2556`	`while (List)`