Skip to content

Commit bd5de40

Browse files
committed
fix tests
1 parent 46b8d49 commit bd5de40

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

dagster_sqlmesh/asset.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
# Define a SQLMesh Asset
1818
def sqlmesh_assets(
1919
*,
20+
environment: str,
2021
config: SQLMeshContextConfig,
2122
name: t.Optional[str] = None,
2223
dagster_sqlmesh_translator: t.Optional[SQLMeshDagsterTranslator] = None,
@@ -28,7 +29,7 @@ def sqlmesh_assets(
2829
controller = DagsterSQLMeshController.setup(config)
2930
if not dagster_sqlmesh_translator:
3031
dagster_sqlmesh_translator = SQLMeshDagsterTranslator()
31-
conversion = controller.to_asset_outs(dagster_sqlmesh_translator)
32+
conversion = controller.to_asset_outs(environment, dagster_sqlmesh_translator)
3233

3334
return multi_asset(
3435
name=name,

dagster_sqlmesh/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ def run(
126126
plan_options["end"] = end
127127
run_options["end"] = end
128128

129-
for _context, event in controller.plan_and_run(
129+
for event in controller.plan_and_run(
130130
environment,
131131
plan_options=plan_options,
132132
run_options=run_options,

dagster_sqlmesh/controller/dagster.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@ class DagsterSQLMeshController(SQLMeshController):
2020
"""An extension of the sqlmesh controller specifically for dagster use"""
2121

2222
def to_asset_outs(
23-
self, translator: SQLMeshDagsterTranslator
23+
self, environment: str, translator: SQLMeshDagsterTranslator
2424
) -> SQLMeshMultiAssetOptions:
25-
with self.context() as context:
25+
with self.instance(environment) as instance:
26+
context = instance.context
2627
dag = context.dag
2728
output = SQLMeshMultiAssetOptions()
2829
depsMap: t.Dict[str, CoercibleToAssetDep] = {}

dagster_sqlmesh/test_asset.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
def test_sqlmesh_context_to_asset_outs(sample_sqlmesh_test_context: SQLMeshTestContext):
88
controller = sample_sqlmesh_test_context.create_controller()
99
translator = SQLMeshDagsterTranslator()
10-
outs = controller.to_asset_outs(translator)
10+
outs = controller.to_asset_outs("dev", translator)
1111
assert len(list(outs.deps)) == 1
1212
assert len(outs.outs) == 7

sample/dagster_project/definitions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def test_source() -> pl.DataFrame:
5050
)
5151

5252

53-
@sqlmesh_assets(config=sqlmesh_config)
53+
@sqlmesh_assets(environment="dev", config=sqlmesh_config)
5454
def sqlmesh_project(context: AssetExecutionContext, sqlmesh: SQLMeshResource):
5555
yield from sqlmesh.run(context)
5656

0 commit comments

Comments
 (0)