Skip to content

Commit 6e2d482

Browse files
committed
refactor(tests): simplify test parameters and improve clarity
- Removed the `no_auto_upstream` parameter from the test function to streamline its signature. - Updated the parameterized test case to focus on `skip_backfill` and `expected_changes`. - Enhanced the test ID for better readability and understanding of the test's purpose.
1 parent ac3c906 commit 6e2d482

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

dagster_sqlmesh/controller/tests_plan_and_run/test_model_code_change.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,9 @@
1111

1212

1313
@pytest.mark.parametrize(
14-
"no_auto_upstream,skip_backfill,expected_changes",
14+
"skip_backfill,expected_changes",
1515
[
1616
(
17-
False,
1817
False,
1918
{
2019
"staging_1": ">=", # Should increase (skip_backfill disabled)
@@ -25,13 +24,12 @@
2524
),
2625
],
2726
ids=[
28-
"only_skip_backfill",
27+
"skip_backfill = False",
2928
],
3029
)
3130
# @pytest.mark.skip(reason="Work in progress test")
3231
def test_given_model_chain_when_running_with_different_flags_then_behaves_as_expected(
3332
sample_sqlmesh_test_context: SQLMeshTestContext,
34-
no_auto_upstream: bool,
3533
skip_backfill: bool,
3634
expected_changes: dict[str, str],
3735
):

0 commit comments

Comments
 (0)