Skip to content

Commit 25993f3

Browse files
committed
fix: rename translator parameters and set defaults
1 parent 29d7eae commit 25993f3

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

dagster_sqlmesh/asset.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def sqlmesh_assets(
2323
config: SQLMeshContextConfig,
2424
context_factory: ContextFactory[ContextCls] = lambda **kwargs: Context(**kwargs),
2525
name: str | None = None,
26-
dagster_sqlmesh_translator: SQLMeshDagsterTranslator | None = None,
26+
dagster_sqlmesh_translator: SQLMeshDagsterTranslator = SQLMeshDagsterTranslator(),
2727
compute_kind: str = "sqlmesh",
2828
op_tags: t.Mapping[str, t.Any] | None = None,
2929
required_resource_keys: set[str] | None = None,
@@ -32,8 +32,6 @@ def sqlmesh_assets(
3232
enabled_subsetting: bool = False,
3333
) -> t.Callable[[t.Callable[..., t.Any]], AssetsDefinition]:
3434
controller = DagsterSQLMeshController.setup_with_config(config=config, context_factory=context_factory)
35-
if not dagster_sqlmesh_translator:
36-
dagster_sqlmesh_translator = dagster_sqlmesh_translator
3735

3836
conversion = controller.to_asset_outs(environment, translator=dagster_sqlmesh_translator)
3937

dagster_sqlmesh/controller/base.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -427,12 +427,12 @@ def setup(
427427
context_factory: ContextFactory[ContextCls],
428428
gateway: str = "local",
429429
log_override: logging.Logger | None = None,
430-
translator_override: SQLMeshDagsterTranslator | None = None,
430+
translator: SQLMeshDagsterTranslator = SQLMeshDagsterTranslator(),
431431
) -> t.Self:
432432
return cls.setup_with_config(
433433
config=SQLMeshContextConfig(path=path, gateway=gateway),
434434
log_override=log_override,
435-
translator_override=translator_override,
435+
translator=translator,
436436
context_factory=context_factory,
437437
)
438438

@@ -443,15 +443,15 @@ def setup_with_config(
443443
config: SQLMeshContextConfig,
444444
context_factory: ContextFactory[ContextCls] = DEFAULT_CONTEXT_FACTORY,
445445
log_override: logging.Logger | None = None,
446-
translator_override: SQLMeshDagsterTranslator | None = None,
446+
translator: SQLMeshDagsterTranslator = SQLMeshDagsterTranslator(),
447447
) -> t.Self:
448448
console = EventConsole(log_override=log_override) # type: ignore
449449
controller = cls(
450450
console=console,
451451
config=config,
452452
log_override=log_override,
453453
context_factory=context_factory,
454-
translator_override=translator_override
454+
translator=translator
455455
)
456456
return controller
457457

@@ -461,13 +461,13 @@ def __init__(
461461
console: EventConsole,
462462
context_factory: ContextFactory[ContextCls],
463463
log_override: logging.Logger | None = None,
464-
translator_override: SQLMeshDagsterTranslator | None = None,
464+
translator: SQLMeshDagsterTranslator = SQLMeshDagsterTranslator(),
465465
) -> None:
466466
self.config = config
467467
self.console = console
468468
self.logger = log_override or logger
469469
self._context_factory = context_factory
470-
self.translator = translator_override or SQLMeshDagsterTranslator()
470+
self.translator = translator
471471
self._context_open = False
472472

473473
def set_logger(self, logger: logging.Logger) -> None:

dagster_sqlmesh/resource.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -417,11 +417,11 @@ def get_controller(
417417
self,
418418
context_factory: ContextFactory[ContextCls],
419419
log_override: logging.Logger | None = None,
420-
translator: SQLMeshDagsterTranslator | None = None
420+
translator: SQLMeshDagsterTranslator = SQLMeshDagsterTranslator(),
421421
) -> DagsterSQLMeshController[ContextCls]:
422422
return DagsterSQLMeshController.setup_with_config(
423423
config=self.config,
424424
context_factory=context_factory,
425425
log_override=log_override,
426-
translator_override=translator
426+
translator=translator
427427
)

0 commit comments

Comments
 (0)