Skip to content

Commit 14cb896

Browse files
committed
refactor(tests): remove obsolete test files and clean up codebase
- Deleted `conftest.py`, `test_asset.py`, `test_sqlmesh_context.py`, and other related test files as they are no longer needed. - Ensured that the remaining tests and functionality remain unaffected by these deletions. - Improved overall codebase clarity by removing obsolete test cases and associated fixtures.
1 parent 57f9313 commit 14cb896

File tree

7 files changed

+9
-10
lines changed

7 files changed

+9
-10
lines changed
File renamed without changes.

tests/controller/base/test__build_plan.py renamed to dagster_sqlmesh/controller/tests_base/test__build_plan.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import pytest
22

3+
from dagster_sqlmesh.conftest import SQLMeshTestContext
34
from dagster_sqlmesh.controller.base import PlanOptions
45
from dagster_sqlmesh.utils import snapshot_id_to_model_name
5-
from tests.conftest import SQLMeshTestContext
66

77

88
def test_given_basic_plan_when_building_then_returns_expected_plan_properties(

tests/context/plan_and_run/test_model_code_change.py renamed to dagster_sqlmesh/controller/tests_plan_and_run/test_model_code_change.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
import pytest
55
from pandas.testing import assert_frame_equal
66

7+
from dagster_sqlmesh.conftest import SQLMeshTestContext
78
from dagster_sqlmesh.controller.base import PlanOptions
8-
from tests.conftest import SQLMeshTestContext
99

1010
logger = logging.getLogger(__name__)
1111

tests/context/plan_and_run/test_models.py renamed to dagster_sqlmesh/controller/tests_plan_and_run/test_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
import pytest
44

5+
from dagster_sqlmesh.conftest import SQLMeshTestContext
56
from dagster_sqlmesh.controller.base import PlanOptions, RunOptions
6-
from tests.conftest import SQLMeshTestContext
77

88
logger = logging.getLogger(__name__)
99

tests/context/plan_and_run/test_seeds.py renamed to dagster_sqlmesh/controller/tests_plan_and_run/test_seeds.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
import pytest
44

5+
from dagster_sqlmesh.conftest import SQLMeshTestContext
56
from dagster_sqlmesh.controller.base import PlanOptions, RunOptions
6-
from tests.conftest import SQLMeshTestContext
77

88
logger = logging.getLogger(__name__)
99

@@ -38,7 +38,6 @@ def test_given_seed_model_when_selected_then_only_builds_seed(
3838
run_options=RunOptions(
3939
execution_time="2024-07-15",
4040
),
41-
4241
select_models=["sqlmesh_example.seed_model_1"],
4342
)
4443

tests/context/test_sqlmesh_context.py renamed to dagster_sqlmesh/controller/tests_plan_and_run/test_sqlmesh_context.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import polars
44
import pytest
55

6+
from dagster_sqlmesh.conftest import SQLMeshTestContext
67
from dagster_sqlmesh.controller.base import PlanOptions, RunOptions
7-
from tests.conftest import SQLMeshTestContext
88

99
logger = logging.getLogger(__name__)
1010

@@ -19,7 +19,7 @@ def test_basic_sqlmesh_context(sample_sqlmesh_test_context: SQLMeshTestContext):
1919
SELECT COUNT(*) as items FROM sqlmesh_example__dev.staging_model_1
2020
"""
2121
)
22-
assert staging_model_count[0][0] == 7
22+
assert staging_model_count[0][0] == 8
2323

2424

2525
def test_sqlmesh_context(sample_sqlmesh_test_context: SQLMeshTestContext):
@@ -61,7 +61,7 @@ def test_sqlmesh_context(sample_sqlmesh_test_context: SQLMeshTestContext):
6161
SELECT COUNT(*) FROM sqlmesh_example__dev.staging_model_1
6262
"""
6363
)
64-
assert staging_model_count[0][0] == 7
64+
assert staging_model_count[0][0] == 8
6565

6666
test_source_model_count = sample_sqlmesh_test_context.query(
6767
"""
@@ -96,7 +96,7 @@ def test_sqlmesh_context(sample_sqlmesh_test_context: SQLMeshTestContext):
9696
SELECT COUNT(*) FROM sqlmesh_example__dev.staging_model_1
9797
"""
9898
)
99-
assert staging_model_count[0][0] == 7
99+
assert staging_model_count[0][0] == 8
100100

101101
test_source_model_count = sample_sqlmesh_test_context.query(
102102
"""

tests/test_asset.py renamed to dagster_sqlmesh/test_asset.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from dagster_sqlmesh.asset import (
22
SQLMeshDagsterTranslator,
33
)
4-
from tests.conftest import SQLMeshTestContext
4+
from dagster_sqlmesh.conftest import SQLMeshTestContext
55

66

77
def test_sqlmesh_context_to_asset_outs(sample_sqlmesh_test_context: SQLMeshTestContext):

0 commit comments

Comments
 (0)