Avoid check PROD environment if repos are not included in release (#1217)

Author: hrcornejo

CHANGELOG.md

@@ -9,6 +9,8 @@
 
 
 ### Fixed
+* Avoid check PROD environment if repos are not included in release ([#1217](https://github.com/opendevstack/ods-jenkins-shared-library/pull/1217))
+* Error generating TIR for infra components ([#1216](https://github.com/opendevstack/ods-jenkins-shared-library/pull/1216))
 * Fix Tailor deployment drifts for D, Q envs ([#1055](https://github.com/opendevstack/ods-jenkins-shared-library/pull/1055))
 
 ## [4.8.1] - 2025-5-13
@@ -20,7 +22,6 @@
 * Do not retrieve components from Jira when using an alternate Jira project and not generating documentation ([#1211](https://github.com/opendevstack/ods-jenkins-shared-library/pull/1211))
 
 ### Fixed
-* Error generating TIR for infra components ([#1216](https://github.com/opendevstack/ods-jenkins-shared-library/pull/1216))
 * Use N/A if there isn't system requirements in DTR ([#1214](https://github.com/opendevstack/ods-jenkins-shared-library/pull/1214))
 * Remove missing tests count ([#1213](https://github.com/opendevstack/ods-jenkins-shared-library/pull/1213))
 

src/org/ods/orchestration/DeployStage.groovy

@@ -88,7 +88,9 @@ class DeployStage extends Stage {
                 def targetEnvironment = project.buildParams.targetEnvironment
                 def targetProject = project.targetProject
                 def installableRepos = this.project.repositories.findAll { repo ->
-                    if (repo.type?.toLowerCase() != MROPipelineUtil.PipelineConfig.REPO_TYPE_ODS_INFRA) {
+                    // We only manage the installable repositories in OpenShift if they are included in the release
+                    if (repo.include
+                        && repo.type?.toLowerCase() != MROPipelineUtil.PipelineConfig.REPO_TYPE_ODS_INFRA) {
                         MROPipelineUtil.PipelineConfig.INSTALLABLE_REPO_TYPES.contains(repo.type)
                     }
                 }

test/groovy/org/ods/orchestration/DeployStageSpec.groovy

@@ -0,0 +1,112 @@
+package org.ods.orchestration
+
+import org.ods.orchestration.scheduler.LeVADocumentScheduler
+import org.ods.orchestration.util.MROPipelineUtil
+import org.ods.orchestration.util.Project
+import org.ods.services.BitbucketService
+import org.ods.services.GitService
+import org.ods.services.OpenShiftService
+import org.ods.services.ServiceRegistry
+import org.ods.util.ILogger
+import org.ods.util.IPipelineSteps
+import org.ods.util.Logger
+import util.PipelineSteps
+import util.SpecHelper
+
+import static util.FixtureHelper.createProject
+
+class DeployStageSpec extends SpecHelper {
+    Project project
+    DeployStage deployStage
+    IPipelineSteps script
+    LeVADocumentScheduler levaDocScheduler
+    OpenShiftService openshiftService
+    MROPipelineUtil util
+    ILogger logger
+    GitService gitService
+    BitbucketService bitbucketService
+
+    def setup() {
+        script = new PipelineSteps()
+        levaDocScheduler = Mock(LeVADocumentScheduler)
+        openshiftService = Mock(OpenShiftService)
+        util = Mock(MROPipelineUtil)
+        logger = new Logger(script, true)
+        project = Spy(createProject())
+        gitService = Mock(GitService)
+        bitbucketService = Mock(BitbucketService)
+
+        createService()
+
+        deployStage = Spy(new DeployStage(script, project, project.data.metadata.repositories, "fake"))
+    }
+
+    ServiceRegistry createService() {
+        def registry = ServiceRegistry.instance
+
+        registry.add(IPipelineSteps, script)
+        registry.add(LeVADocumentScheduler, levaDocScheduler)
+        registry.add(OpenShiftService, openshiftService)
+        registry.add(MROPipelineUtil, util)
+        registry.add(Logger, logger)
+        registry.add(GitService, gitService)
+        registry.add(BitbucketService, bitbucketService)
+
+        return registry
+    }
+
+    def "deploy in Q with 3 installable repos (all included)"() {
+        given:
+        project.buildParams.targetEnvironment = 'qa'
+        project.buildParams.targetEnvironmentToken = 'Q'
+        project.targetProject = "net-test"
+
+        when:
+        deployStage.run()
+
+        then:
+        1 * bitbucketService.getUrl() >> "https://bitbucket"
+        1 * project.targetClusterIsExternal >> false
+        1 * openshiftService.envExists(project.targetProject) >> true
+    }
+
+    def "deploy in Q with 3 installable repos (none included)"() {
+        given:
+        project.buildParams.targetEnvironment = 'qa'
+        project.buildParams.targetEnvironmentToken = 'Q'
+        project.targetProject = "net-test"
+        for (repo in project.data.metadata.repositories) {
+            repo.include = false
+        }
+
+        when:
+        deployStage.run()
+
+        then:
+        1 * bitbucketService.getUrl() >> "https://bitbucket"
+        0 * project.targetClusterIsExternal >> false
+        0 * openshiftService.envExists(project.targetProject) >> true
+    }
+
+    def "deploy in Q with 2 installable repos (none included) and one infra"() {
+        given:
+        project.buildParams.targetEnvironment = 'qa'
+        project.buildParams.targetEnvironmentToken = 'Q'
+        project.targetProject = "net-test"
+        for (repo in project.data.metadata.repositories) {
+            if (repo.id == "demo-app-catalogue") {
+                repo.type = "ods-infra"
+            } else {
+                repo.include = false
+            }
+        }
+
+        when:
+        deployStage.run()
+
+        then:
+        1 * bitbucketService.getUrl() >> "https://bitbucket"
+        0 * project.targetClusterIsExternal >> false
+        0 * openshiftService.envExists(project.targetProject) >> true
+    }
+}