Skip to content

FIX: Loosen session error on mismatch #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Jun 19, 2025

Fixes nipreps/fmriprep#3474

If the session parameter isn't used, allow overrides from bids filters.

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.54%. Comparing base (d118beb) to head (8579918).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   71.53%   71.54%           
=======================================
  Files          89       89           
  Lines        8648     8651    +3     
  Branches     1075     1076    +1     
=======================================
+ Hits         6186     6189    +3     
  Misses       2230     2230           
  Partials      232      232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies merged commit 782d5f0 into master Jun 19, 2025
35 checks passed
@effigies effigies deleted the fix/bids-collect-session-id branch June 19, 2025 13:54
effigies added a commit that referenced this pull request Jun 19, 2025
1.13.5 (June 19, 2025)

Patch release in the 1.13.x series.

* FIX: Allow optional/None filters to be overridden (#956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bids filter for session not working in 25.1.2
2 participants