Description
What happened?
As a part of the refactor of fMRIPrep to PETPrep (https://github.com/nipreps/petprep/), I ran into a few issues when using the nipreps.json metadata for the derivatives datasink. Specifically,
- There seemed to be missing a case with _petref suffix, to allow for a case similar to boldref, used for e.g. motion correction. Proposed change (line 181):
" sub-{subject}[/ses-{session}]/{datatype|pet}/sub-{subject}[_ses-{session}][_acq-{acquisition}][_ce-{ceagent}][_rec-{reconstruction}][_run-{run}][_space-{space}][_cohort-{cohort}][_res-{resolution}][desc-{desc}]{suffix<pet|petref>}{extension<.nii|.nii.gz|.json>|.nii.gz}",
"
-
Missing 'pet' datatype. Proposed change on lines 88-91
"name": "datatype",
"pattern": "[/\\]+(func|anat|pet|fmap|dwi|perf|meg|eeg|figures)[/\\]+" -
There also seemed to be missing a case with datatype 'pet' and then a "_timeseries" suffix, to allow for the creation of a confounds file with motion data etc.
Proposed change on line 187:
" "sub-{subject}[/ses-{session}]/{datatype|pet}/sub-{subject}[_ses-{session}][_acq-{acquisition}][_ce-{ceagent}][_rec-{reconstruction}][_dir-{direction}][_run-{run}][_part-{part}][_space-{space}][_cohort-{cohort}][desc-{desc}]{suffix<timeseries|regressors>|timeseries}{extension<.json|.tsv>|.tsv}",
"
What command did you use?
fmriprep /Users/martinnorgaard/Documents/GitHub/petprep_dev/fmriprep/data/tests/pet /Users/martinnorgaard/Documents/GitHub/petprep_dev/fmriprep/data/tests/pet/derivatives participant --fs-subjects-dir /Users/martinnorgaard/Documents/GitHub/petprep_dev/fmriprep/data/tests/pet/derivatives/freesurfer --reference-frame 10 --no-msm --skull-strip-t1w skip
What version of the software are you running?
1.13.3
How are you running this software?
Local installation ("bare-metal")
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
FreeSurfer
Please copy and paste any relevant log output.
Additional information / screenshots
No response