Skip to content

Commit b048f4e

Browse files
authored
refactor: apply suggestions from code review
1 parent e6f31f0 commit b048f4e

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ It handles the automated creation, renewal and use of SSL certificates for proxi
2424
* The (sub)domains you want to issue certificates for must correctly resolve to the host.
2525
* If your (sub)domains have AAAA records set, the host must be publicly reachable over IPv6 on port `80` and `443`.
2626

27-
If you can't meet these requirements, you can use the `DNS-01` challenge instead. Please refer to the [documentation](./docs/Let's-Encrypt-and-ACME.md#dns-01-acme-challenge) for more information.
27+
If you can't meet these requirements, you can use the `DNS-01` challenge instead. Please refer to the [documentation](https://github.com/nginx-proxy/acme-companion/blob/main/docs/Let's-Encrypt-and-ACME.md#dns-01-acme-challenge) for more information.
2828

2929
In addition to the above, please ensure that your DNS provider answers correctly to CAA record requests. [If your DNS provider answer with an error, Let's Encrypt won't issue a certificate for your domain](https://letsencrypt.org/docs/caa/). Let's Encrypt do not require that you set a CAA record on your domain, just that your DNS provider answers correctly.
3030

app/start.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ term_handler() {
77

88
# shellcheck source=functions.sh
99
source /app/functions.sh
10-
if parse_true "${ACME_HTTP_CHALLENGE_LOCATION:=false}"; then
11-
remove_all_location_configurations
12-
fi
10+
remove_all_location_configurations
1311
remove_all_standalone_configurations
1412

1513
exit 0

0 commit comments

Comments
 (0)