Skip to content

Commit d30ade8

Browse files
authored
Update EditorTranslationParserPlugin signature for Godot 4.4 (#799)
1 parent 29e53fd commit d30ade8

File tree

2 files changed

+7
-15
lines changed

2 files changed

+7
-15
lines changed

Dialogue Manager.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Godot.NET.Sdk/4.4.0-beta.3">
1+
<Project Sdk="Godot.NET.Sdk/4.4.0-rc.1">
22
<PropertyGroup>
33
<TargetFramework>net8.0</TargetFramework>
44
<EnableDynamicLoading>true</EnableDynamicLoading>

addons/dialogue_manager/editor_translation_parser_plugin.gd

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ var translated_character_names: PackedStringArray = []
88
var translated_lines: Array[Dictionary] = []
99

1010

11-
func _parse_file(path: String, msgids: Array, msgids_context_plural: Array) -> void:
11+
func _parse_file(path: String) -> Array[PackedStringArray]:
12+
var msgs: Array[PackedStringArray] = []
1213
var file: FileAccess = FileAccess.open(path, FileAccess.READ)
1314
var text: String = file.get_as_text()
1415

@@ -25,7 +26,7 @@ func _parse_file(path: String, msgids: Array, msgids_context_plural: Array) -> v
2526
known_keys.append(character_name)
2627

2728
translated_character_names.append(character_name)
28-
msgids_context_plural.append([character_name.replace('"', '\"'), "dialogue", ""])
29+
msgs.append(PackedStringArray([character_name.replace('"', '\"'), "dialogue", "", DMConstants.translate("translation_plugin.character_name")]))
2930

3031
# Add all dialogue lines and responses
3132
var dialogue: Dictionary = data.lines
@@ -41,20 +42,11 @@ func _parse_file(path: String, msgids: Array, msgids_context_plural: Array) -> v
4142
known_keys.append(translation_key)
4243
translated_lines.append(line)
4344
if translation_key == line.text:
44-
msgids_context_plural.append([line.text.replace('"', '\"'), "", ""])
45+
msgs.append(PackedStringArray([line.text.replace('"', '\"'), "", "", line.get("notes", "")]))
4546
else:
46-
msgids_context_plural.append([line.text.replace('"', '\"'), line.translation_key.replace('"', '\"'), ""])
47+
msgs.append(PackedStringArray([line.text.replace('"', '\"'), line.translation_key.replace('"', '\"'), "", line.get("notes", "")]))
4748

48-
49-
func _get_comments(msgids_comment: Array[String], msgids_context_plural_comment: Array[String]) -> void:
50-
# Add all character names if settings ask for it
51-
if DMSettings.get_setting(DMSettings.INCLUDE_CHARACTERS_IN_TRANSLATABLE_STRINGS_LIST, true):
52-
for character_name in translated_character_names:
53-
msgids_context_plural_comment.append(DMConstants.translate("translation_plugin.character_name"))
54-
55-
# Add all dialogue lines and responses
56-
for line: Dictionary in translated_lines:
57-
msgids_context_plural_comment.append(line.get("notes", ""))
49+
return msgs
5850

5951

6052
func _get_recognized_extensions() -> PackedStringArray:

0 commit comments

Comments
 (0)