Skip to content

Commit 63b3532

Browse files
authored
Fix runtime expression error checking (#920)
1 parent 7900315 commit 63b3532

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

addons/dialogue_manager/dialogue_manager.gd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,8 @@ func get_resolved_line_data(data: Dictionary, extra_game_states: Array = []) ->
299299
text_replacements = _expression_parser.extract_replacements(text, 0)
300300

301301
for replacement in text_replacements:
302-
assert(not replacement.has("error"), "%s \"%s\"" % [DMConstants.get_error_message(replacement.get("error")), text])
302+
if replacement.has("error"):
303+
assert(false, "%s \"%s\"" % [DMConstants.get_error_message(replacement.get("error")), text])
303304

304305
var value = await _resolve(replacement.expression.duplicate(true), extra_game_states)
305306
var index: int = text.find(replacement.value_in_text)

0 commit comments

Comments
 (0)