Skip to content

Commit 8599174

Browse files
stephan-ghsamcday
authored andcommitted
arm64: dts: qcom: msm8916: Pull-up the UART RX pin
With UART disconnected, no one is driving the UART RX line. It will be floating, which can end up producing garbage on stdin. Reliable UART is particularly important in early boot stages, otherwise an autoboot sequence might be interrupted, so bootph-all is also added to the RX pin. Co-developed-by: Sam Day <me@samcday.com> Signed-off-by: Sam Day <me@samcday.com> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
1 parent 1728ab7 commit 8599174

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

arch/arm64/boot/dts/qcom/msm8916.dtsi

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1279,10 +1279,20 @@
12791279
};
12801280

12811281
blsp_uart2_default: blsp-uart2-default-state {
1282-
pins = "gpio4", "gpio5";
1283-
function = "blsp_uart2";
1284-
drive-strength = <16>;
1285-
bias-disable;
1282+
tx-pins {
1283+
pins = "gpio4";
1284+
function = "blsp_uart2";
1285+
drive-strength = <16>;
1286+
bias-disable;
1287+
};
1288+
rx-pins {
1289+
pins = "gpio5";
1290+
function = "blsp_uart2";
1291+
drive-strength = <16>;
1292+
bias-pull-up;
1293+
bootph-all;
1294+
};
1295+
12861296
};
12871297

12881298
blsp_uart2_sleep: blsp-uart2-sleep-state {

0 commit comments

Comments
 (0)