Skip to content

chore: remove unit tag from tests #4071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2025
Merged

chore: remove unit tag from tests #4071

merged 3 commits into from
Aug 1, 2025

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Aug 1, 2025 •
edited
Loading

Proposed changes

removes --tags="unit" for unit tests, we are adding a -short to skip e2e tests, which is native to go test.

Jira ticket: CLOUDP-#

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes marked this pull request as ready for review August 1, 2025 08:46
@fmenezes fmenezes requested a review from a team as a code owner August 1, 2025 08:46
@fmenezes fmenezes enabled auto-merge (squash) August 1, 2025 08:46
@coveralls
Copy link
Collaborator

coveralls commented Aug 1, 2025 •
edited
Loading

Coverage Status

coverage: 57.953% (-7.1%) from 65.017%
when pulling 36c1c05 on chore_remove_unit_tag
into fbf4387 on master.

andreaangiolillo
andreaangiolillo approved these changes Aug 1, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes merged commit ed04f12 into master Aug 1, 2025
26 of 27 checks passed
@fmenezes fmenezes deleted the chore_remove_unit_tag branch August 1, 2025 09:28
@fmenezes fmenezes mentioned this pull request Aug 1, 2025
Merged
6 tasks
cveticm
cveticm reviewed Aug 1, 2025
View reviewed changes
@fmenezes fmenezes mentioned this pull request Aug 5, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cveticm cveticm cveticm left review comments

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmenezes @coveralls @andreaangiolillo @cveticm