Skip to content

Commit 67bf569

Browse files
committed
NR feedback
1 parent a853a47 commit 67bf569

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

source/upgrade.txt

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,9 @@ The v4.1 driver introduces the following breaking changes to the ABI:
150150

151151
.. _version-4.1-enable-tests-config:
152152

153-
- Sets the ``ENABLE_TESTS`` configuration option to ``OFF`` by default,
154-
including for auto-downloaded versions of the {+driver-short+}. To
155-
re-enable building test targets, you must set ``ENABLE_TESTS`` to ``ON``.
156-
To include test targets in the "all" target, you must also set the
157-
``BUILD_TESTING`` option to ``ON``.
153+
- Sets the ``ENABLE_TESTS`` configuration option to ``OFF`` by default for
154+
auto-downloaded versions of the {+driver-short+}. :ref:`This is an expansion of the
155+
change made in v4.0. <version-4.0-enable-tests-config>`
158156

159157
.. _version-4.0-breaking-changes:
160158

@@ -179,11 +177,18 @@ The v4.0 driver introduces the following breaking changes to the build system:
179177
- Drops support for the ``MONGOCXX_OVERRIDE_DEFAULT_INSTALL_PREFIX`` configuration
180178
option. Default CMake behavior for ``CMAKE_INSTALL_PREFIX`` is now respected.
181179

182-
.. note::
180+
.. _version-4.0-enable-tests-config:
181+
182+
- Sets the ``ENABLE_TESTS`` configuration option to ``OFF`` by default. To
183+
re-enable building test targets, you must set ``ENABLE_TESTS`` to ``ON``.
184+
To include test targets in the "all" target, you must also set the
185+
``BUILD_TESTING`` option to ``ON``.
186+
187+
.. note::
183188

184-
The :ref:`ENABLE_TESTS configuration option change
185-
<version-4.1-enable-tests-config>` was originally announced for v4.0, but
186-
instead was released with v4.1.
189+
This change does not apply to auto-downloaded versions of the
190+
{+driver-short+}. :ref:`The change for auto-downloaded versions was added in
191+
v4.1. <version-4.1-enable-tests-config>`
187192

188193
.. _version-4.0-api-breaking:
189194

0 commit comments

Comments
 (0)