Skip to content

Commit efd1247

Browse files
authored
channel was not properly initialized in several pubsub client managers (#1476)
1 parent 3a002e6 commit efd1247

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/socketio/async_aiopika_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ def __init__(self, url='amqp://guest:guest@localhost:5672//',
4343
raise RuntimeError('aio_pika package is not installed '
4444
'(Run "pip install aio_pika" in your '
4545
'virtualenv).')
46+
super().__init__(channel=channel, write_only=write_only, logger=logger)
4647
self.url = url
4748
self._lock = asyncio.Lock()
4849
self.publisher_connection = None
4950
self.publisher_channel = None
5051
self.publisher_exchange = None
51-
super().__init__(channel=channel, write_only=write_only, logger=logger)
5252

5353
async def _connection(self):
5454
return await aio_pika.connect_robust(self.url)

src/socketio/async_redis_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ def __init__(self, url='redis://localhost:6379/0', channel='socketio',
5252
'(Run "pip install redis" in your virtualenv).')
5353
if not hasattr(aioredis.Redis, 'from_url'):
5454
raise RuntimeError('Version 2 of aioredis package is required.')
55+
super().__init__(channel=channel, write_only=write_only, logger=logger)
5556
self.redis_url = url
5657
self.redis_options = redis_options or {}
5758
self._redis_connect()
58-
super().__init__(channel=channel, write_only=write_only, logger=logger)
5959

6060
def _redis_connect(self):
6161
if not self.redis_url.startswith('redis+sentinel://'):

src/socketio/redis_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ def __init__(self, url='redis://localhost:6379/0', channel='socketio',
7575
raise RuntimeError('Redis package is not installed '
7676
'(Run "pip install redis" in your '
7777
'virtualenv).')
78+
super().__init__(channel=channel, write_only=write_only, logger=logger)
7879
self.redis_url = url
7980
self.redis_options = redis_options or {}
8081
self._redis_connect()
81-
super().__init__(channel=channel, write_only=write_only, logger=logger)
8282

8383
def initialize(self):
8484
super().initialize()

src/socketio/zmq_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ def __init__(self, url='zmq+tcp://localhost:5555+5556',
5757
if not (url.startswith('zmq+tcp://') and r.search(url)):
5858
raise RuntimeError('unexpected connection string: ' + url)
5959

60+
super().__init__(channel=channel, write_only=write_only, logger=logger)
6061
url = url.replace('zmq+', '')
6162
(sink_url, sub_port) = url.split('+')
6263
sink_port = sink_url.split(':')[-1]
@@ -72,7 +73,6 @@ def __init__(self, url='zmq+tcp://localhost:5555+5556',
7273
self.sink = sink
7374
self.sub = sub
7475
self.channel = channel
75-
super().__init__(channel=channel, write_only=write_only, logger=logger)
7676

7777
def _publish(self, data):
7878
pickled_data = pickle.dumps(

0 commit comments

Comments
 (0)