TypeError: Cannot read properties of undefined (reading 'number') (#4894) (#4903)

alexr00 · web-flow · commit 45f6afb56500 · 2023-06-12T10:51:29.000+02:00
diff --git a/src/github/githubRepository.ts b/src/github/githubRepository.ts
@@ -468,6 +468,9 @@ export class GitHubRepository implements vscode.Disposable {
 
 			if (data?.repository.pullRequests.nodes.length > 0) {
 				const prs = data.repository.pullRequests.nodes.map(node => parseGraphQLPullRequest(node, this)).filter(pr => pr.head?.repo.owner === headOwner);
+				if (prs.length === 0) {
+					return undefined;
+				}
 				const mostRecentOrOpenPr = prs.find(pr => pr.state.toLowerCase() === 'open') ?? prs[0];
 				return this.createOrUpdatePullRequestModel(mostRecentOrOpenPr);
 			}

Original file line number	Diff line number	Diff line change
`@@ -468,6 +468,9 @@ export class GitHubRepository implements vscode.Disposable {`
`468`	`468`
`469`	`469`	`if (data?.repository.pullRequests.nodes.length > 0) {`
`470`	`470`	`const prs = data.repository.pullRequests.nodes.map(node => parseGraphQLPullRequest(node, this)).filter(pr => pr.head?.repo.owner === headOwner);`
	`471`	`+ if (prs.length === 0) {`
	`472`	`+ return undefined;`
	`473`	`+ }`
`471`	`474`	`const mostRecentOrOpenPr = prs.find(pr => pr.state.toLowerCase() === 'open') ?? prs[0];`
`472`	`475`	`return this.createOrUpdatePullRequestModel(mostRecentOrOpenPr);`
`473`	`476`	`}`