Skip to content

Commit 052ab00

Browse files
authored
Replacing a label with another appears to work in vscode but doesn't (#4496)
Part of #4492
1 parent 38bb90c commit 052ab00

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/github/createPRViewProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ export class CreatePullRequestViewProvider extends WebviewViewBase implements vs
413413

414414
private async setLabels(pr: PullRequestModel, labels: ILabel[]): Promise<void> {
415415
if (labels.length > 0) {
416-
await pr.addLabels(labels.map(label => label.name));
416+
await pr.setLabels(labels.map(label => label.name));
417417
}
418418
}
419419

src/github/issueModel.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,10 +249,10 @@ export class IssueModel<TItem extends Issue = Issue> {
249249
}
250250
}
251251

252-
async addLabels(labels: string[]): Promise<void> {
252+
async setLabels(labels: string[]): Promise<void> {
253253
const { octokit, remote } = await this.githubRepository.ensure();
254254
try {
255-
await octokit.call(octokit.api.issues.addLabels, {
255+
await octokit.call(octokit.api.issues.setLabels, {
256256
owner: remote.owner,
257257
repo: remote.repositoryName,
258258
issue_number: this.number,

src/github/issueOverview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
241241
);
242242

243243
if (labelsToAdd && labelsToAdd.length) {
244-
await this._item.addLabels(labelsToAdd.map(r => r.label));
244+
await this._item.setLabels(labelsToAdd.map(r => r.label));
245245
const addedLabels: ILabel[] = labelsToAdd.map(label => newLabels.find(l => l.name === label.label)!);
246246

247247
this._item.item.labels = addedLabels;

0 commit comments

Comments
 (0)