Skip to content

Commit 685a542

Browse files
committed
Throw from browser and context fixtures
1 parent aef9f29 commit 685a542

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

tests/extension/extensionTest.ts

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export type ExtensionTestFixtures = {
3131

3232

3333
export const extensionTest = baseTest.extend<TraceViewerFixtures>(traceViewerFixtures).extend<PageTestFixtures, PageWorkerFixtures & ExtensionTestFixtures>({
34-
browserVersion: [({ browser }, use) => use(browser.version()), { scope: 'worker' }],
34+
browserVersion: [({ persistentContext }, use) => use(persistentContext.browser().version()), { scope: 'worker' }],
3535
browserMajorVersion: [({ browserVersion }, use) => use(Number(browserVersion.split('.')[0])), { scope: 'worker' }],
3636
isAndroid: [false, { scope: 'worker' }],
3737
isElectron: [false, { scope: 'worker' }],
@@ -66,23 +66,15 @@ export const extensionTest = baseTest.extend<TraceViewerFixtures>(traceViewerFix
6666
await context.close();
6767
}, { scope: 'worker' }],
6868

69-
browser: [async ({ persistentContext, relayServer, playwright }, use, testInfo) => {
70-
const origin = `ws://localhost:${(relayServer.address() as AddressInfo).port}`;
71-
await expect.poll(() => persistentContext.serviceWorkers()).toHaveLength(1);
72-
await persistentContext.pages()[0].goto(new URL('/popup.html', persistentContext.serviceWorkers()[0].url()).toString());
73-
await persistentContext.pages()[0].getByRole('textbox', { name: 'Bridge Server URL:' }).clear();
74-
await persistentContext.pages()[0].getByRole('textbox', { name: 'Bridge Server URL:' }).fill(`${origin}/extension`);
75-
await persistentContext.pages()[0].getByRole('button', { name: 'Share This Tab' }).click();
76-
await persistentContext.pages()[0].goto('about:blank');
77-
const browser = await playwright.chromium.connectOverCDP(`${origin}/cdp`);
78-
await use(browser);
69+
browser: [async ({ }, use) => {
70+
throw new Error('Not supported in the extension tests');
7971
}, { scope: 'worker' }],
8072

81-
context: async ({ browser }, use) => {
82-
await use(browser.contexts()[0]);
73+
context: async ({ }, use) => {
74+
throw new Error('Not supported in the extension tests');
8375
},
8476

85-
page: async ({ persistentContext, relayServer, playwright }, use) => {
77+
page: async ({ persistentContext, relayServer, playwright, server }, use) => {
8678
const page = await persistentContext.newPage();
8779
const origin = `ws://localhost:${(relayServer.address() as AddressInfo).port}`;
8880
await expect.poll(() => persistentContext.serviceWorkers()).toHaveLength(1);

0 commit comments

Comments
 (0)