relax typing in sameConcept()

Author: pjmolina

doc/Changelog.md

@@ -0,0 +1,9 @@
+# Essential Core Changelog
+
+## Version 1.0.1 / 2024.12.05
+
+- Relax typing for `sameConcept`.
+
+## Version 1.0.0 / 2024.12.04
+
+- Initial Version

src/modelElement.ts

@@ -49,7 +49,7 @@ export interface ModelElement {
 
   // equality. generic
   hashCode(): number;
-  sameConcept(b: ModelElement): boolean;
+  sameConcept(b: ModelElement | null | undefined): boolean;
   equals(b: ModelElement): boolean;
 
   // mergeWith(b: ModelElement): void;

src/modelElementBase.ts

@@ -42,7 +42,7 @@ export class ModelElementBase implements ModelElement {
   /**
    * sameConcept check. based on same identity
    */
-  sameConcept(b: ModelElement): boolean {
+  sameConcept(b: ModelElement | null | undefined): boolean {
     if (!b) {
       return false;
     }
@@ -140,7 +140,7 @@ export class ModelElementBase implements ModelElement {
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   visitChildren(visitMode: VisitMode, action: (el: ModelElement) => void) {
     // Overriden in descendent clases
-    throw new Error('Unimplemented');
+    //throw new Error('Unimplemented');
   }
   validate(): ErrorBase[] {
     return [];