Critical bug: mistake in expfile generation logic

martinpaljak · martinpaljak · commit a042e356844f · 2024-11-19T10:06:52.000+02:00
diff --git a/task/src/main/java/pro/javacard/ant/JCCap.java b/task/src/main/java/pro/javacard/ant/JCCap.java
@@ -575,7 +575,7 @@ private void convert(Path applet_folder, List<Path> exps) {
 
         // determine output types
         String outputs = "CAP";
-        if (output_exp != null || (raw_applets.size() > 1 && verify)) {
+        if (output_exp != null || (raw_applets.size() > 0 && verify)) {
             outputs += " EXP";
         }
         if (output_jca != null) {

Original file line number	Diff line number	Diff line change
`@@ -575,7 +575,7 @@ private void convert(Path applet_folder, List<Path> exps) {`
`575`	`575`
`576`	`576`	`// determine output types`
`577`	`577`	`String outputs = "CAP";`
`578`		`- if (output_exp != null \|\| (raw_applets.size() > 1 && verify)) {`
	`578`	`+ if (output_exp != null \|\| (raw_applets.size() > 0 && verify)) {`
`579`	`579`	`outputs += " EXP";`
`580`	`580`	`}`
`581`	`581`	`if (output_jca != null) {`