Merge branch 'master' of https://github.com/major/MySQLTuner-perl

Author: jmrenouard

.gitignore

@@ -3,3 +3,4 @@ build/mysqltuner.spec
 build/build.log
 build/cve*
 build/vulnerabilities*
+*.bak

CONTRIBUTING.md

@@ -27,7 +27,7 @@ following restrictions:
   respect the opinions of others.
 
 
-##Before submitting an issue##
+## Before submitting an issue
 
 1. Upgrade to the latest version of MySQLTuner and see if the problem remains
 
@@ -47,7 +47,7 @@ Good bug reports are extremely helpful — thank you!
 
 Guidelines for bug reports:
 
-1. **Use the [GitHub issue search](https://github.com/major/MySQLTuner-perl/search?type=Issues)** — check if the issue has already been
+1. **Use the [GitHub issue search]** — check if the issue has already been
    reported.
 
 2. **Check if the bug has already been fixed** — try to reproduce it using the
@@ -100,13 +100,13 @@ to MySQLTuner will be evaluated on a combination of scope (how well it fits into
 project), maintenance burden and general usefulness.
 
 Creating something great often means saying no to seemingly good ideas. Don't
-dispair if your feature request isn't accepted, take action! Fork the
+despair if your feature request isn't accepted, take action! Fork the
 repository, build your idea and share it with others. We released MySQLTuner under
 the MIT License for this purpose precisely. Open source works best when smart
 and dedicated people riff off of each others' ideas to make even greater things.
 
-## New feature request ##
-* You can find Enhancement asked by community at [Enhancement issue](https://github.com/major/MySQLTuner-perl/labels/enhancement)
+## New feature request
+You can find Enhancement asked by community at [Enhancement issue]
 
 <a name="pull-requests"></a>
 ## Pull requests
@@ -153,8 +153,7 @@ these guidelines is the best way to get your work included in MySQLTuner.
    git checkout -b <topic-branch-name>
    ```
 
-4. Commit your changes in logical chunks. Please adhere to these [git commit
-   message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
+4. Commit your changes in logical chunks. Please adhere to these [git commit message guidelines]
    or your code is unlikely be merged into the main project. Use Git's
    [interactive rebase](https://help.github.com/articles/interactive-rebase)
    feature to tidy up your commits before making them public.
@@ -171,18 +170,23 @@ these guidelines is the best way to get your work included in MySQLTuner.
    git push origin <topic-branch-name>
    ```
 
-7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
-    with a clear title and description.
+7. [Open a Pull Request] with a clear title and description.
 
 **IMPORTANT**: By submitting a patch, you agree to allow the project owner to
-license your work under the [GPLv3 License](https://en.wikipedia.org/wiki/GNU_General_Public_License).
+license your work under the [GPLv3 License].
 
-Copy of the license is available at [LICENSE](https://github.com/major/MySQLTuner-perl/blob/master/LICENSE)
+Copy of the license is available at [LICENSE]
 
 <a name="code-conventions"></a>
-#### MySQLTuner Code Conventions
+## MySQLTuner Code Conventions
 
 1. Check code convention using **perltidy** and **perlcritic**
 2. Don't manually update the version number in `mysqltuner.pl`. 
- 
 
+
+[Enhancement issue]:https://github.com/major/MySQLTuner-perl/labels/enhancement
+[GitHub issue search]:https://github.com/major/MySQLTuner-perl/search?type=Issues
+[git commit message guidelines]:http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
+[Open a Pull Request]:https://help.github.com/articles/using-pull-requests/
+[GPLv3 License]:https://en.wikipedia.org/wiki/GNU_General_Public_License
+[LICENSE]:https://github.com/major/MySQLTuner-perl/blob/master/LICENSE

INTERNALS.md

@@ -249,6 +249,10 @@
 	* Joiner(Try to reach cluster group)
 	* SYNCED state able to read/write
 * wsrep_cluster_conf_id configuration level must be identical in all nodes
+* wsrep_slave_thread is between 3 or 4 times number of CPU core.
+* gcs.limit should be equal to wsrep_slave_threads * 5
+* gcs.fc_factor should be equal to 0.8
+* Flow control fraction should be lower than 0.02 (wsrep_flow_control_paused < 0.02)
 * wsrep_last_commited committed level must be identical in all nodes
 * Look for tables without primary keys
 * Look for non InnoDB tables for Galera
@@ -292,7 +296,9 @@
 * thread_pool_size between 4 to 8 for MyIsam usage
 
 ## MySQLTuner performance schema and sysschema information
-
+* Check that Performance schema is activated for 5.6+ version
+* Check that Performance schema is disactivated for 5.5- version
+* Check that Sys schema is installed
 * sys Schema version
 * Top user per connection
 * Top user per statement

README.md

@@ -11,10 +11,10 @@ MySQLTuner-perl
 
 **MySQLTuner** supports in this last version ~300 indicators for MySQL/MariaDB/Percona Server. 
 
-**MySQLTuner** is maintained and indicator collect is increasing week after week supporting a lot of configuration such as ![Galera Cluster](http://galeracluster.com/), ![TokuDB](https://www.percona.com/software/mysql-database/percona-tokudb), ![                                                                                                                         Performance schema](https://github.com/mysql/mysql-sys), Linux OS metrics, ![InnoDB](http://dev.mysql.com/doc/refman/5.7/en/innodb-storage-engine.html), ![MyISAM](http://dev.mysql.com/doc/refman/5.7/en/myisam-storage-engine.html), ![Aria](https://mariadb.com/kb/en/mariadb/aria/), ... 
+**MySQLTuner** is maintained and indicator collect is increasing week after week supporting a lot of configuration such as [Galera Cluster](http://galeracluster.com/), [TokuDB](https://www.percona.com/software/mysql-database/percona-tokudb), [Performance schema](https://github.com/mysql/mysql-sys), Linux OS metrics, [InnoDB](http://dev.mysql.com/doc/refman/5.7/en/innodb-storage-engine.html), [MyISAM](http://dev.mysql.com/doc/refman/5.7/en/myisam-storage-engine.html), [Aria](https://mariadb.com/kb/en/mariadb/aria/), ... 
 
-You can found more details on this indicators 
-![Indicators description](https://github.com/major/MySQLTuner-perl/blob/master/INTERNALS.md).
+You can find more details on these indicators here:
+[Indicators description](https://github.com/major/MySQLTuner-perl/blob/master/INTERNALS.md).
 
 
 ![MysqlTuner](https://github.com/major/MySQLTuner-perl/blob/master/mysqltuner.png)
@@ -24,7 +24,7 @@ MySQLTuner needs you:
 
 **MySQLTuner** needs contributors for documentation, code and feedbacks..
 
-* Please join us on issue track at [GitHub tracker](https://github.com/major/MySQLTuner-perl/issues)</a>.
+* Please join us on issue track at [GitHub tracker](https://github.com/major/MySQLTuner-perl/issues).
 * Contribution guide is available following [MySQLTuner contributing guide](https://github.com/major/MySQLTuner-perl/blob/master/CONTRIBUTING.md)
 * Star **MySQLTuner project** at [MySQLTuner Git Hub Project](https://github.com/major/MySQLTuner-perl)
 
@@ -57,6 +57,14 @@ MySQL in other areas.
 
 **Seriously - please review the FAQ section below.**
 
+
+Security recommandations
+--
+
+Hi directadmin user! 
+We detected that you run mysqltuner with da_admin's credentials taken from /usr/local/directadmin/conf/my.cnf, which might bring to a password discovery! 
+Read link for more details [Issue #289](https://github.com/major/MySQLTuner-perl/issues/289).
+
 What MySQLTuner is checking exactly ? 
 --
 All checks done by **MySQLTuner** are documented in [MySQLTuner Internals](https://github.com/major/MySQLTuner-perl/blob/master/INTERNALS.md) documentation.
@@ -230,7 +238,7 @@ MySQLTuner needs you
 --
 **MySQLTuner** needs contributors for documentation, code and feedbacks..
 
-* Please join us on issue track at [GitHub tracker](https://github.com/major/MySQLTuner-perl/issues)</a>.
+* Please join us on issue track at [GitHub tracker](https://github.com/major/MySQLTuner-perl/issues).
 * Contribution guide is avalaible following [MySQLTuner contributing guide](https://github.com/major/MySQLTuner-perl/blob/master/CONTRIBUTING.md)
 * Star **MySQLTuner project** at [MySQLTuner Git Hub Project](https://github.com/major/MySQLTuner-perl)
 

USAGE.md

@@ -1,6 +1,6 @@
 # NAME
 
-    MySQLTuner 1.6.20 - MySQL High Performance Tuning Script
+    MySQLTuner 1.7.0 - MySQL High Performance Tuning Script
 
 # IMPORTANT USAGE GUIDELINES
 
@@ -15,7 +15,9 @@ You must provide the remote server's total memory when connecting to other serve
     --socket <socket>    Use a different socket for a local connection
     --port <port>        Port to use for connection (default: 3306)
     --user <username>    Username to use for authentication
+    --userenv <envvar>   Name of env variable which contains username to use for authentication
     --pass <password>    Password to use for authentication
+    --passenv <envvar>   Name of env variable which contains password to use for authentication
     --mysqladmin <path>  Path to a custom mysqladmin executable
     --mysqlcmd <path>    Path to a custom mysql executable
      --defaults-file <path>  Path to a custom .my.cnf
@@ -40,7 +42,7 @@ You must provide the remote server's total memory when connecting to other serve
     --dbstat                    Print database information
     --idxstat                   Print index information
     --sysstat                   Print system information
-    --pfstat                    Print Performance schema 
+    --pfstat                    Print Performance schema
     --bannedports               Ports banned separated by comma(,)
     --maxportallowed            Number of ports opened allowed on this hosts
     --cvefile                   CVE File for vulnerability checks

build/updateCVElist.pl

@@ -64,9 +64,11 @@ sub AUTOLOAD {
 
         foreach my $vers (uniq(@versions)) {
             my @nb=split('\.', $vers);
+            $nb[2]-- if ($line =~ /before/i);
             #print $vers."\n".Dumper @nb;
-            #exit 0;
-            $f->write_file('file' => '../vulnerabilities.csv', 'content' => "$vers;$nb[0];$nb[1];$nb[2];$line\n", 'mode' => 'append');
+            #print "$line";
+            #exit 0 if ($line =~/before/i) ;
+            $f->write_file('file' => '../vulnerabilities.csv', 'content' => "$nb[0].$nb[1].$nb[2];$nb[0];$nb[1];$nb[2];$line\n", 'mode' => 'append');
         }
 	}
 }

build/updateStaff.sh

@@ -0,0 +1,15 @@
+#!/bin/sh
+
+(cd ..
+echo "* GENERATING USAGE FILE"
+pod2markdown mysqltuner.pl >USAGE.md
+echo "* TIDYFY SCRIPT"
+perltidy -b mysqltuner.pl
+)
+echo "* Udate CVE list"
+perl updateCVElist.pl
+
+git add ../vulnerabilities.csv ../mysqltuner.pl ./USAGE.md
+git commit -m 'Update Vulnerabilities list
+Identing mysqltuner
+Update Usage information'