chromedp.Dump doesn't work

[feeops]

the code

package main

import (
	"context"
	"fmt"
	"github.com/chromedp/chromedp"
	"os"
)

func run() {

	t := "https://www.youtube.com"

	allocatorCtx, _ := chromedp.NewRemoteAllocator(context.Background(), "ws://127.0.0.1:9222")
	ctx, _ := chromedp.NewContext(allocatorCtx)
	var url string
	if err := chromedp.Run(ctx, []chromedp.Action{
		chromedp.Navigate(t),
		// chromedp.Sleep(10 * time.Second),

		chromedp.Location(&url),
		chromedp.Dump("html", os.Stdout),
	}...); err != nil {
		fmt.Println("t", err)
	}

	fmt.Println("URL:", url)

}

func main() {

	run()
}

output

t context canceled
URL: https://www.youtube.com/

 ./lightpanda version
bdc49a6

[krichprollsch]

Hello @feeops,

Thanks for you issue.
It looks like we don't support chromedp.Dump for now.
I will take a look at it to see how it is implemented.

In the meanwhile, you can achieve an equivalent result with:

package main

import (
	"context"
	"fmt"

	"github.com/chromedp/chromedp"
)

func run() {
	t := "https://www.youtube.com"
	var content string

	allocatorCtx, _ := chromedp.NewRemoteAllocator(context.Background(), "ws://127.0.0.1:9222")
	ctx, _ := chromedp.NewContext(allocatorCtx)
	var url string
	if err := chromedp.Run(ctx, []chromedp.Action{
		chromedp.Navigate(t),
		// chromedp.Sleep(10 * time.Second),

		chromedp.Location(&url),
		chromedp.OuterHTML("html", &content),
	}...); err != nil {
		fmt.Println("t", err)
	}

	fmt.Println(content)
	fmt.Println("t", url)

}

func main() {
	run()
}

[karlseguin]

The original code using chromedp.Dump should be working.

However, I noticed that Chrome doesn't emit every node, whereas we do. It looks like maybe it leaves out script tags. I need to investigate this more..but for now, i figure having too much data is still a step in the right direction.