Simplify character data handling

Author: dwarring

lib/LibXML/DocumentFragment.rakumod

@@ -60,9 +60,11 @@ use LibXML::Element;
 use LibXML::Node;
 use NativeCall;
 use Method::Also;
-use LibXML::Parser::Context;
 
-class ParserContext is LibXML::Parser::Context {
+class ParserContext {
+    use LibXML::Parser::Context;
+    also is LibXML::Parser::Context;
+
     has LibXML::DocumentFragment $.doc-frag is required;
     has Int $.stat is rw;
     has Str $.string;
@@ -72,9 +74,7 @@ class ParserContext is LibXML::Parser::Context {
 
     submethod DESTROY {
         $lock.protect: {
-            if $!nodes {
-                $!nodes.FreeList();
-            }
+            .FreeList() with $!nodes;
         }
     }
     method publish {

lib/LibXML/Raw.rakumod

@@ -913,7 +913,7 @@ class anyNode is export does LibXML::Raw::DOM::Node {
     method GetNodePath(--> xmlAllocedStr) is native($XML2) is symbol('xmlGetNodePath') {*}
     method AddChild(anyNode --> anyNode) is native($XML2) is symbol('xmlAddChild') {*}
     method AddChildList(anyNode --> anyNode) is native($XML2) is symbol('xmlAddChildList') {*}
-    method AddContent(xmlCharP) is native($XML2) is symbol('xmlNodeAddContent') {*}
+    method AddContent(xmlCharP --> int32) is native($XML2) is symbol('xmlNodeAddContent') {*}
     method SetContext(xmlXPathContext --> int32) is symbol('xmlXPathSetContextNode') is native($XML2) {*}
     method XPathEval(Str, xmlXPathContext --> xmlXPathObject) is symbol('xmlXPathNodeEval') is native($XML2) {*}
     method domXPathSelectStr(Str --> xmlNodeSet) is native($BIND-XML2) {*}

lib/LibXML/_CharacterData.rakumod

@@ -15,21 +15,18 @@ multi method new(Str:D() $content, *%c) {
 
 method data {...}
 method cloneNode {...}
-method !substr(|c) {$.data.substr(|c)}
-method !substr-rw(|c) is rw {$.data.substr-rw(|c)}
-
 method length { $.data.chars }
 
 # DOM Boot-leather
-method substringData(UInt:D $off, UInt:D $len --> Str) { self!substr($off, $len) }
-method appendData(Str:D $val --> Str) { self!substr-rw(*-0, 0) = $val }
-method insertData(UInt:D $pos, Str:D $val) { self!substr-rw($pos, 0) = $val; }
-method setData(Str:D $val --> Str) { self!substr-rw(0, *) = $val; }
+method substringData(UInt:D $off, UInt:D $len --> Str) { $.data.substr($off, $len) }
+method appendData(Str:D $val --> Str) { self.appendText($val); $.data; }
+method insertData(UInt:D $pos, Str:D $val) { $.data.substr-rw($pos, 0) = $val; }
+method setData(Str:D $val --> Str) { $.data = $val; }
 method getData returns Str { $.data }
 multi method replaceData(UInt:D $off, UInt:D $length, Str:D $val --> Str) {
     my $len = $.length;
     if $len > $off {
-        self!substr-rw($off, $length) = $val;
+        $.data.substr-rw($off, $length) = $val;
     }
     else {
         Str