Merge pull request #92 from willjones-stratagem/bugfix-MethodGenerator-Parameter-Position

Make MethodGenerator parameter sorting preserve array keys

Author: Ocramius

src/Generator/MethodGenerator.php

@@ -15,7 +15,7 @@
 use function strtolower;
 use function substr;
 use function trim;
-use function usort;
+use function uasort;
 
 class MethodGenerator extends AbstractMemberGenerator
 {
@@ -315,7 +315,7 @@ public function setReturnsReference($returnsReference)
      */
     private function sortParameters(): void
     {
-        usort($this->parameters, static function (ParameterGenerator $item1, ParameterGenerator $item2) {
+        uasort($this->parameters, static function (ParameterGenerator $item1, ParameterGenerator $item2) {
             return $item1->getPosition() <=> $item2->getPosition();
         });
     }

test/Generator/MethodGeneratorTest.php

@@ -106,7 +106,7 @@ public function testSetMethodParameters()
             return $parameter->getName();
         }, $params);
 
-        self::assertEquals(['foo', 'baz', 'bar'], $sorting);
+        self::assertEquals(['foo' => 'foo', 'baz' => 'baz', 'bar' => 'bar'], $sorting);
     }
 
     public function testMethodBodyGetterAndSetter()