Skip to content

Commit 709c963

Browse files
committed
Address review feedback
1 parent 62e4abc commit 709c963

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

contributors/devel/sig-architecture/api-conventions.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -877,7 +877,9 @@ For example, a map field marked with `+nullable` would accept either `foo: null`
877877

878878
Usage of `+nullable` is discouraged as it introduces several issues:
879879
- It is not compatible with json merge patching.
880-
- It is not compatible with generic protobuf.
880+
- From the [JSON Merge Patch RFC](https://tools.ietf.org/html/rfc7386#section-1):
881+
> Null values in the merge patch are given special meaning to indicate the removal of existing values in the target.
882+
- Explicit `null` values are not be persisted in proto serializations
881883

882884
## Defaulting
883885

0 commit comments

Comments
 (0)