Skip to content

Commit 936bf03

Browse files
authored
Merge pull request #16 from kinde-oss/leo/start_page
fix: avoid forcing login
2 parents e4db7a4 + b3f9ca0 commit 936bf03

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ interface RegisterURLOptions {
632632
Notice that you are able to override the `state` parameter in `RegisterURLOptions`,
633633
if not provided then the SDK will assign a random string to this value, this
634634
applies to the `login` method discussed below as well. In addition it must be
635-
noted that interally this method will ensure the resulting registration URL has
635+
noted that internally this method will ensure the resulting registration URL has
636636
the `start_page` query parameter to `'registration'`.
637637

638638
### `login`
@@ -655,8 +655,6 @@ interface LoginURLOptions {
655655
state?: string;
656656
}
657657
```
658-
In addition it must be noted that interally this method will ensure that the
659-
resulting login URL has the `start_page` query parameter to `'login'`.
660658

661659
### `createOrg`
662660
This method will return a registration URL, with the `is_create_org` parameter
@@ -677,7 +675,7 @@ interface CreateOrgURLOptions {
677675
state?: string;
678676
}
679677
```
680-
In addition it must be noted that as in the `registration` method above interally
678+
In addition it must be noted that as in the `registration` method above internally
681679
this method will also set the `start_page` query parameter to `'registration'`.
682680
in the resulting URL.
683681

lib/sdk/clients/browser/authcode-with-pkce.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ const createAuthCodeWithPKCEClient = (options: PKCEClientOptions) => {
2929
*/
3030
const login = async (options?: LoginURLOptions): Promise<URL> => {
3131
return await client.createAuthorizationURL(sessionManager, {
32-
...options,
33-
start_page: 'login',
32+
...options
3433
});
3534
};
3635

lib/sdk/clients/server/authorization-code.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ const createAuthorizationCodeClient = (
3030
options?: LoginURLOptions
3131
): Promise<URL> => {
3232
return await client.createAuthorizationURL(sessionManager, {
33-
...options,
34-
start_page: 'login',
33+
...options
3534
});
3635
};
3736

0 commit comments

Comments
 (0)