Remove redundant nullability suppressions

bkoelman · bkoelman · commit db8ee0a10f8e · 2025-08-02T02:18:53.000+02:00
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/OperationsDbContext.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/OperationsDbContext.cs
@@ -21,7 +21,7 @@ protected override void OnModelCreating(ModelBuilder builder)
     {
         builder.Entity<MusicTrack>()
             .HasOne(musicTrack => musicTrack.Lyric)
-            .WithOne(lyric => lyric.Track!)
+            .WithOne(lyric => lyric.Track)
             .HasForeignKey<MusicTrack>("LyricId");
 
         builder.Entity<MusicTrack>()
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/CompositeKeys/CompositeDbContext.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/CompositeKeys/CompositeDbContext.cs
@@ -30,7 +30,7 @@ protected override void OnModelCreating(ModelBuilder builder)
 
         builder.Entity<Dealership>()
             .HasMany(dealership => dealership.Inventory)
-            .WithOne(car => car.Dealership!);
+            .WithOne(car => car.Dealership);
 
         builder.Entity<Car>()
             .HasMany(car => car.PreviousDealerships)
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/InputValidation/ModelState/ModelStateDbContext.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/InputValidation/ModelState/ModelStateDbContext.cs
@@ -24,7 +24,7 @@ protected override void OnModelCreating(ModelBuilder builder)
 
         builder.Entity<SystemDirectory>()
             .HasMany(systemDirectory => systemDirectory.Subdirectories)
-            .WithOne(systemDirectory => systemDirectory.Parent!);
+            .WithOne(systemDirectory => systemDirectory.Parent);
 
         builder.Entity<SystemDirectory>()
             .HasOne(systemDirectory => systemDirectory.Self)
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/QueryStringDbContext.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/QueryStringDbContext.cs
@@ -28,7 +28,7 @@ protected override void OnModelCreating(ModelBuilder builder)
     {
         builder.Entity<WebAccount>()
             .HasMany(webAccount => webAccount.Posts)
-            .WithOne(blogPost => blogPost.Author!);
+            .WithOne(blogPost => blogPost.Author);
 
         builder.Entity<Man>()
             .HasOne(man => man.Wife)
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/ReadWriteDbContext.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/ReadWriteDbContext.cs
@@ -29,7 +29,7 @@ protected override void OnModelCreating(ModelBuilder builder)
 
         builder.Entity<WorkItemGroup>()
             .HasOne(workItemGroup => workItemGroup.Color)
-            .WithOne(color => color.Group!)
+            .WithOne(color => color.Group)
             .HasForeignKey<RgbColor>("GroupId");
 
         builder.Entity<WorkItem>()
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/ResourceDefinitions/Serialization/SerializationDbContext.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/ResourceDefinitions/Serialization/SerializationDbContext.cs
@@ -17,7 +17,7 @@ protected override void OnModelCreating(ModelBuilder builder)
     {
         builder.Entity<Scholarship>()
             .HasMany(scholarship => scholarship.Participants)
-            .WithOne(student => student.Scholarship!);
+            .WithOne(student => student.Scholarship);
 
         base.OnModelCreating(builder);
     }
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/ZeroKeys/ZeroKeyDbContext.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/ZeroKeys/ZeroKeyDbContext.cs
@@ -18,7 +18,7 @@ protected override void OnModelCreating(ModelBuilder builder)
     {
         builder.Entity<Game>()
             .HasMany(game => game.Maps)
-            .WithOne(map => map.Game!);
+            .WithOne(map => map.Game);
 
         builder.Entity<Player>()
             .HasOne(player => player.ActiveGame)

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ protected override void OnModelCreating(ModelBuilder builder)`
`21`	`21`	`{`
`22`	`22`	`builder.Entity<MusicTrack>()`
`23`	`23`	`.HasOne(musicTrack => musicTrack.Lyric)`
`24`		`- .WithOne(lyric => lyric.Track!)`
	`24`	`+ .WithOne(lyric => lyric.Track)`
`25`	`25`	`.HasForeignKey<MusicTrack>("LyricId");`
`26`	`26`
`27`	`27`	`builder.Entity<MusicTrack>()`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ protected override void OnModelCreating(ModelBuilder builder)`
`28`	`28`	`{`
`29`	`29`	`builder.Entity<WebAccount>()`
`30`	`30`	`.HasMany(webAccount => webAccount.Posts)`
`31`		`- .WithOne(blogPost => blogPost.Author!);`
	`31`	`+ .WithOne(blogPost => blogPost.Author);`
`32`	`32`
`33`	`33`	`builder.Entity<Man>()`
`34`	`34`	`.HasOne(man => man.Wife)`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ protected override void OnModelCreating(ModelBuilder builder)`
`17`	`17`	`{`
`18`	`18`	`builder.Entity<Scholarship>()`
`19`	`19`	`.HasMany(scholarship => scholarship.Participants)`
`20`		`- .WithOne(student => student.Scholarship!);`
	`20`	`+ .WithOne(student => student.Scholarship);`
`21`	`21`
`22`	`22`	`base.OnModelCreating(builder);`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ protected override void OnModelCreating(ModelBuilder builder)`
`18`	`18`	`{`
`19`	`19`	`builder.Entity<Game>()`
`20`	`20`	`.HasMany(game => game.Maps)`
`21`		`- .WithOne(map => map.Game!);`
	`21`	`+ .WithOne(map => map.Game);`
`22`	`22`
`23`	`23`	`builder.Entity<Player>()`
`24`	`24`	`.HasOne(player => player.ActiveGame)`