Remove reflection-based workaround

Author: bkoelman

src/JsonApiDotNetCore.OpenApi.Swashbuckle/SchemaRepositoryExtensions.cs

@@ -1,34 +1,11 @@
 using System.Diagnostics.CodeAnalysis;
-using System.Reflection;
 using Microsoft.OpenApi;
 using Swashbuckle.AspNetCore.SwaggerGen;
 
 namespace JsonApiDotNetCore.OpenApi.Swashbuckle;
 
 internal static class SchemaRepositoryExtensions
 {
-    private const string ReservedIdsFieldName = "_reservedIds";
-    private static readonly FieldInfo ReservedIdsField = GetReservedIdsField();
-
-    private static FieldInfo GetReservedIdsField()
-    {
-        FieldInfo? field = typeof(SchemaRepository).GetField(ReservedIdsFieldName, BindingFlags.Instance | BindingFlags.NonPublic);
-
-        if (field == null)
-        {
-            throw new InvalidOperationException($"Failed to locate private field '{ReservedIdsFieldName}' " +
-                $"in type '{typeof(SchemaRepository).FullName}' in assembly '{typeof(SchemaRepository).Assembly.FullName}'.");
-        }
-
-        if (field.FieldType != typeof(Dictionary<Type, string>))
-        {
-            throw new InvalidOperationException($"Unexpected type '{field.FieldType}' of private field '{ReservedIdsFieldName}' " +
-                $"in type '{typeof(SchemaRepository).FullName}' in assembly '{typeof(SchemaRepository).Assembly.FullName}'.");
-        }
-
-        return field;
-    }
-
     public static OpenApiSchemaReference LookupByType(this SchemaRepository schemaRepository, Type schemaType)
     {
         ArgumentNullException.ThrowIfNull(schemaRepository);
@@ -48,24 +25,4 @@ public static bool TryLookupByTypeSafe(this SchemaRepository schemaRepository, T
         referenceSchema = result ? obliviousReferenceSchema : null;
         return result;
     }
-
-    public static void ReplaceSchemaId(this SchemaRepository schemaRepository, Type oldSchemaType, string newSchemaId)
-    {
-        ArgumentNullException.ThrowIfNull(schemaRepository);
-        ArgumentNullException.ThrowIfNull(oldSchemaType);
-        ArgumentException.ThrowIfNullOrEmpty(newSchemaId);
-
-        if (schemaRepository.TryLookupByTypeSafe(oldSchemaType, out OpenApiSchemaReference? referenceSchema))
-        {
-            string oldSchemaId = referenceSchema.GetReferenceId();
-
-            IOpenApiSchema targetSchema = schemaRepository.Schemas[oldSchemaId];
-
-            schemaRepository.Schemas.Remove(oldSchemaId);
-            schemaRepository.Schemas.Add(newSchemaId, targetSchema);
-
-            var reservedIds = (Dictionary<Type, string>)ReservedIdsField.GetValue(schemaRepository)!;
-            reservedIds.Remove(oldSchemaType);
-        }
-    }
 }