feat(getSlidingPercent rule): (#19)

* feat(getSlidingPercent rule):

* fix(rules): remove leftover console log

Author: mhartington

src/ionItemOptionMethodGetSlidingPercentRenamedRule.ts

@@ -0,0 +1,30 @@
+import * as Lint from 'tslint';
+import * as ts from 'typescript';
+export const ruleName = 'ion-item-option-method-get-sliding-percent-renamed';
+export const ruleMessage = '"getSlidingPercent" has been renamed to "getSlidingRatio"';
+
+class GetSlidingPercentRenamedWalker extends Lint.RuleWalker {
+  visitCallExpression(node: ts.CallExpression) {
+    const expression = node.expression as any;
+    if (expression.name && expression.name.text === 'getSlidingPercent') {
+      const replacement = new Lint.Replacement(expression.name.getStart(), expression.name.getWidth(), 'getSlidingRatio');
+      this.addFailure(this.createFailure(expression.name.getStart(), expression.name.getWidth(), ruleMessage, replacement));
+    }
+  }
+}
+
+export class Rule extends Lint.Rules.AbstractRule {
+  public static metadata: Lint.IRuleMetadata = {
+    ruleName: ruleName,
+    type: 'functionality',
+    description: 'getSlidingPercent is now called getSlidingRatio.',
+    options: null,
+    optionsDescription: 'Not configurable.',
+    typescriptOnly: true,
+    hasFix: true
+  };
+
+  public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
+    return this.applyWithWalker(new GetSlidingPercentRenamedWalker(sourceFile, this.getOptions()));
+  }
+}

test/ionItemOptionMethodGetSlidingPercentRenamed.spec.ts

@@ -0,0 +1,38 @@
+import { expect } from 'chai';
+import { ruleName, ruleMessage } from '../src/ionItemOptionMethodGetSlidingPercentRenamedRule';
+import { assertAnnotated, assertSuccess } from './testHelper';
+
+describe(ruleName, () => {
+  describe('success', () => {
+    it('should work with new method name', () => {
+      let source = `
+      class DoSomething{
+        constructor(){}
+        getRatio(item: ItemSliding){
+          return item.getSlidingRatio();
+        }
+      }
+        `;
+      assertSuccess(ruleName, source);
+    });
+  });
+
+  describe('failure', () => {
+    it('should fail when using getSlidingPercent', () => {
+      let source = `
+      class DoSomething{
+        constructor(){}
+        getRatio(item: ItemSliding){
+          return item.getSlidingPercent();
+                      ~~~~~~~~~~~~~~~~~
+        }
+      }
+        `;
+      assertAnnotated({
+        ruleName,
+        message: ruleMessage,
+        source
+      });
+    });
+  });
+});