Skip to content

Commit 2daf538

Browse files
committed
fix size_t conversion issue that was failing to build on some compilers in the sdist
1 parent 1d45042 commit 2daf538

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

docs/benchmarks/ebm-benchmark.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"force_recreate = False\n",
1818
"exist_ok = True\n",
1919
"TIMEOUT_SEC = 60 * 60 * 24 * 180 # 180 days\n",
20-
"wheel_filepaths = ['interpret_core-0.6.8-py3-none-any.whl', 'powerlift-0.1.12-py3-none-any.whl']\n",
20+
"wheel_filepaths = ['interpret_core-0.6.9-py3-none-any.whl', 'powerlift-0.1.12-py3-none-any.whl']\n",
2121
"\n",
2222
"import datetime\n",
2323
"experiment_name = datetime.datetime.now().strftime('%Y_%m_%d_%H%M__') + 'myexperiment'\n",

shared/libebm/PartitionMultiDimensionalCorner.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ template<bool bHessian, size_t cCompilerScores> class PartitionMultiDimensionalC
240240
} while(cRealDimensions != iDimInit);
241241
}
242242

243-
const size_t cTotalSamples = pTotal->GetCountSamples();
243+
const size_t cTotalSamples = static_cast<size_t>(pTotal->GetCountSamples());
244244

245245
TensorSumDimension
246246
aDimensions[k_dynamicDimensions == cCompilerDimensions ? k_cDimensionsMax : cCompilerDimensions];
@@ -286,8 +286,8 @@ template<bool bHessian, size_t cCompilerScores> class PartitionMultiDimensionalC
286286
#endif // NDEBUG
287287
);
288288

289-
if(cSamplesLeafMin <= pTempBin->GetCountSamples()) {
290-
const size_t cSamplesOther = cTotalSamples - pTempBin->GetCountSamples();
289+
if(cSamplesLeafMin <= static_cast<size_t>(pTempBin->GetCountSamples())) {
290+
const size_t cSamplesOther = cTotalSamples - static_cast<size_t>(pTempBin->GetCountSamples());
291291
if(cSamplesLeafMin <= cSamplesOther) {
292292
EBM_ASSERT(1 <= cScores);
293293
size_t iScore = 0;

shared/libebm/tests/boosting_unusual_inputs.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2289,7 +2289,8 @@ static double RandomizedTesting(const AccelerationFlags acceleration) {
22892289
TermBoostFlags_PurifyUpdate,
22902290
// TermBoostFlags_GradientSums, // does not return a metric
22912291
TermBoostFlags_DisableNewtonUpdate,
2292-
TermBoostFlags_RandomSplits};
2292+
TermBoostFlags_RandomSplits,
2293+
TermBoostFlags_Corners};
22932294
std::vector<IntEbm> boostFlagsChoose{
22942295
TermBoostFlags_Default, TermBoostFlags_MissingLow, TermBoostFlags_MissingHigh, TermBoostFlags_MissingSeparate};
22952296

@@ -2367,7 +2368,7 @@ static double RandomizedTesting(const AccelerationFlags acceleration) {
23672368
}
23682369

23692370
TEST_CASE("stress test, boosting") {
2370-
const double expected = 12298977636064.098;
2371+
const double expected = 14219338182453.824;
23712372

23722373
double validationMetricExact = RandomizedTesting(AccelerationFlags_NONE);
23732374
CHECK(validationMetricExact == expected);

0 commit comments

Comments
 (0)